Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable terminal event batching from ptyHost #116468

Closed
Tyriar opened this issue Feb 11, 2021 · 1 comment · Fixed by #117268
Closed

Enable terminal event batching from ptyHost #116468

Tyriar opened this issue Feb 11, 2021 · 1 comment · Fixed by #117268
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release perf terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
March 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 11, 2021

Using TerminalDataBufferer for local terminals
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label perf labels Feb 11, 2021
@Tyriar Tyriar added this to the February 2021 milestone Feb 11, 2021
@Tyriar Tyriar mentioned this issue Feb 11, 2021
Closed
@Tyriar Tyriar mentioned this issue Feb 18, 2021
Merged
meganrogge added a commit that referenced this issue Feb 22, 2021
@meganrogge
fix #116468
ff010b7
@meganrogge meganrogge mentioned this issue Feb 22, 2021
Merged
@meganrogge meganrogge modified the milestones: February 2021, March 2021 Feb 23, 2021
@Tyriar Tyriar assigned Tyriar and unassigned meganrogge Mar 18, 2021
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Mar 24, 2021
@Tyriar Tyriar assigned meganrogge and unassigned Tyriar Mar 25, 2021
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Mar 26, 2021
meganrogge added a commit that referenced this issue Mar 26, 2021
@meganrogge
Enable terminal event batching from ptyHost (#117268)
2a8113f 
* fix #116468
Co-authored-by: Daniel Imms <[email protected]>
jrieken pushed a commit that referenced this issue Mar 29, 2021
@meganrogge @jrieken
Enable terminal event batching from ptyHost (#117268)
2a60d7f 
* fix #116468
Co-authored-by: Daniel Imms <[email protected]>
@Tyriar Tyriar removed the unreleased Patch has not yet been released in VS Code Insiders label Mar 29, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Mar 29, 2021

Verification steps: In both local and remote windows, run a few terminal commands including one intensive one (eg. ls -lR ~/tree)and ensure it acts properly.

@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Mar 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release perf terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

Successfully merging a pull request may close this issue.

Enable terminal event batching from ptyHost microsoft/vscode
4 participants
@Tyriar @TylerLeonhardt @meganrogge and others