Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transitioning from viewing an image to editing an image #116120

Closed
Tyriar opened this issue Feb 8, 2021 · 5 comments
Closed

Support transitioning from viewing an image to editing an image #116120

Tyriar opened this issue Feb 8, 2021 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 8, 2021

Idea: have a pencil icon as an editor action as an entry point to image editor extensions.

@Tyriar Tyriar added the plan-item VS Code - planned item for upcoming label Feb 8, 2021
@Tyriar Tyriar added this to the February 2021 milestone Feb 8, 2021
@Tyriar Tyriar self-assigned this Feb 8, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Feb 9, 2021

Proposal:

recording (1)

Tyriar added a commit that referenced this issue Feb 9, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Feb 18, 2021

Feedback summary so far:

  • Standardize "recommendations" as a lightbulb icon
    • Use a lightbulb instead of a pencil?
      • Not sure this conveys the right message that editing is possible like the pencil does
  • A pencil means edit, not download and edit
    • Include a download icon or lightbulb icon in bottom right or something?
  • Hardcoding the extension vs supporting generically
    • Would this be something that extension authors can define in their package.json?
    • Other extensions might want to do the same and add icons to promote other extensions
  • This feels like a different flow for getting into a recommendation
    • It’s a trade off to break the pattern to provide a softer/less annoying recommendation
    • This does help those newer users that don’t know about recommendations
  • Should we support external image editors?
    • Probably best left up to specific extensions to add their own menu entries with tailors icons/text
  • Have a badge on the extension activity bar icon if there are contextual recommendations?

@innerlee
Copy link
Contributor

Will vscode evolve into photoshop?

@Tyriar
Copy link
Member Author

Tyriar commented Feb 23, 2021

@innerlee VS Code will remain an extensible editor, but I'm building https://marketplace.visualstudio.com/items?itemName=Tyriar.luna-paint in my spare time which uses VS Code as a platform.

@Tyriar Tyriar modified the milestones: February 2021, Backlog Feb 24, 2021
@Tyriar Tyriar added feature-request Request for new features or functionality and removed plan-item VS Code - planned item for upcoming labels Feb 24, 2021
@Tyriar Tyriar changed the title Explore transition from viewing an image to editing an image Support transitioning from viewing an image to editing an image Feb 24, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Dec 13, 2022

Not planning on pursuing in the near future

@Tyriar Tyriar closed this as completed Dec 13, 2022
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

2 participants