Skip to content

Ports view polish #116058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
egamma opened this issue Feb 7, 2021 · 3 comments
Closed
8 tasks done

Ports view polish #116058

egamma opened this issue Feb 7, 2021 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan remote-explorer Remote explorer view
Milestone

Comments

@egamma
Copy link
Member

egamma commented Feb 7, 2021

Ports View

  • Use a tabular rendering of the Ports view, leveraging the planned table widget
  • Show an icon that indicates the 'state' of the port (running/not runnig/running elevated)
  • Move Ports view to Panel, a table doesn't work well in the place constrained sidebar.
  • Render the ports exposed by extension process in a custom way Ports info: servers started from the EH: info too long hard to understand #115213
  • Show an inline action to copy the target URL (remove closing the port action from the list of inline actions)
  • Improve the text message shown in the welcome view. Suggestion: 'No forwarded ports, forward a port to access your running services'

Ports Notification

@egamma egamma added this to the February 2021 milestone Feb 7, 2021
@alexr00 alexr00 added feature-request Request for new features or functionality remote-explorer Remote explorer view labels Feb 8, 2021
alexr00 added a commit that referenced this issue Feb 8, 2021
alexr00 added a commit that referenced this issue Feb 9, 2021
@alexr00
Copy link
Member

alexr00 commented Feb 15, 2021

The remaining polish items here are best tackled as part of the table view exploration. Once the table widget is available I'll continue! (#99997)

We're still awaiting more data on whether to move the ports view to the panel permanently.

@alexr00
Copy link
Member

alexr00 commented Feb 18, 2021

Here's where we're at:
image

Forwarded ports have a filled circle icon if there's a running process or an outline circle if not.
Each cell can have it's own actions, so the "close" inline action is in the first column. The other actions are in the local address column since they are directly related to the local address. This includes the newly added inline copy action.

@alexr00
Copy link
Member

alexr00 commented Feb 19, 2021

View has been moved to the panel.
After feedback:
image

I am sure there will be more tweaking of the UI in the next couple days, but all of the polish items here have now been completed.

@alexr00 alexr00 closed this as completed Feb 19, 2021
@alexr00 alexr00 added verification-needed Verification of issue is requested and removed verification-needed Verification of issue is requested labels Feb 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan remote-explorer Remote explorer view
Projects
None yet
Development

No branches or pull requests

2 participants