-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insiders on macOS ARM64: Extension Host crashes (SIGILL
, EFAULT
, EPIPE
)
#113410
Comments
Possibly relevant, this is also in the developer tools log:
|
Error: read EFAULT
SIGILL
, EFAULT
, EPIPE
)
One other error I've been seeing in developer tools prior to an
|
New one:
|
Likely relevant for this issue: fsevents/fsevents#349 |
@deepak1556 if you need any further information kindly let me know. This seems to specify that it's running on node 12, but node 12 isn't compatible with arm64 (at least not the general purpose one). Only node 15 is. Is this right? Also, fsevents/fsevents#350 has been merged and pending release as |
Can you run the arm64 insiders in a new user data dir
The runtime is patched to work in electron. |
@deepak1556 I ran:
Then had to use Still got the crash: (hopefully Note that it happens randomly, I've seen it mostly happen when the angular app I'm running in the integrated terminal detects a code change and starts compiling. However, it can happen without any integrated terminal tasks running as well. What I've been doing and helps a bit, was to run It's possible it is related to file change detection though. In this particular crash above, it crashed immediately after saving a file, and when angular started recompiling (running via |
Attaching the CPU profile of the |
Can you also try to remove the As for the git integration slowdown, its triggered by child_process.spawn calls based on your profile and the root issue is tracked in upstream electron/electron#26143 |
I have disabled the Live Share Extension Pack which I wasn't really using and it seems that things are a lot better. I noticed it was taking part in the Not sure if this fixes it yet, but there haven't been any crashes in a while. |
FWIW, both VSCode Exploration and Insiders exhibit the problem, and I installed both fresh arm64 on a fresh macOS installation. This was a new Mac, so I didn't restore from anything. The crashes have been super consistent for me, at least once every 10 minutes or so. If no one else reported this, it's probably a combination of the electron issue you linked and some extensions I'm using. I'll keep monitoring whether disabling Live Share helped and report back. |
If the crash continues, can you start the app with |
I've been trying real hard for the past hour to make it crash since disabling the Live Share pack, and I wasn't able to. I assume the pack installs a code lens provider that runs The performance, prior to disabling it, was horrible overall. I can't believe how smooth it is now. Thanks for pointing out that bug. Just a heads up that |
Thanks for the work! chokidar just released a version with it. Will update shortly. |
It looks like eventually it still crashed, even without the live share extension pack. It took way longer though. 🤔 Going to run with crash dump reporting now. Still seeing this logged btw:
Have seen it a bunch of times, always related to |
@deepak1556 I just had another crash of the Extension Host, this time with a new code. Attaching crash dump: 09b42d44-5dd7-42ae-b463-3342d4c0e9aa.dmp.zip That file was in the |
Attaching a dump from a crash with code |
Yes thats the correct directory to look for dumps, symbolicated trace for SIGSEGV crash
this would be nodejs/node#34833 , that issue reports its fixed in v14. We can ignore this for now. |
As for the SIGILL dumps,
|
Both the dumps indicate the crash happens after call to |
The Do you think there's any way to get it to produce a stack trace or more useful logs for the I can reproduce those relatively easy under memory pressure. (PS: I will run with |
@andreialecu maybe because the setting isn't getting picked up by the extension. All my problems are fixed, but running my code and tests via bash command line. /cc @huming2207 |
@vassudanagunta I've tested it. Some VSCode plugins have WebAssembly stuff in there. If you set V8 in VSCode to JIT-less, the WS related API will be disabled. So it's not an option here. |
@vassudanagunta @huming2207 there should be no wasm related crashes with latest insiders, this issue is mainly tracking a crash under memory pressure. |
@deepak1556 Yes I agree. I think this is off-topic as it's related to the permission issue nodejs/node#37061 only. |
node v15.9.0 has been released with the fix for nodejs/node#37061. |
@andreialecu the applications with which you see |
@deepak1556 I haven't really seen But I have been able to reproduce Unfortunately I don't have further info besides what people in nodejs/node#36826 have been posting. Overall Insiders has been pretty stable lately. I did not see any additional SIGILL crashes besides that single one 14 days ago. But again, I suspect these errors may be more prevalent on the 8GB of RAM M1. If I open Developer Tools I see some random errors logged there most of the time. But things seem to be fine. Here's one example, but I'm not sure if these are related to this particular issue: |
Thanks for the details, that helps. |
I'm experiencing this regularly on the stable release (I was previously insiders) Version: 1.54.1 (Universal) I will provide a stack trace when it happens again if thats useful |
@purge what's the RAM capacity of your M1? And which error, |
@andreialecu it was EFAULT (I do experience SIGILLs in node though) i have 16Gb and it definitely appears to be related to memory pressure. |
this happened again today with SIGILL. It may just be nodejs/node#36826
|
@purge see: #113410 (comment) The command I was using was: I haven't personally seen any |
Lately I have seen a crash of the extension host on macOS 11.x ARM almost daily. |
Have we determined that it's memory related? Or is it something like network sockets timing out/disconnecting/becoming invalidated? |
Since I posted in April, I have not seen a single extension host crash ever since. I am still using macOS ARM. |
Agreed, i have not seen it for months either. not sure whether its was node or macos update that fixed it. |
Is anyone in this thread actively experiencing this issue on latest macOS Big Sur 11.4 and VS Code version |
@deepak1556 There has been some activity here nodejs/node#36826 (comment) and a report of a SIGSEGV with the extension host under high memory pressure. Luckily a nodejs contributor is looking into it, so perhaps we'll have some answers soon. Personally, I haven't seen almost any crashes in a long time. I use VSCode 8+ hrs per day and in the past 3 months or so I only got one extension host crash or maybe two. (It might still happen more often on a 8GB machine though.) Edit: just noticed you were involved in that same discussion, and the conclusion was that macOS 11.4 might have fixed it. |
Yup I am now looking for users who are hitting this issue on |
Closing per above comment. |
Issue Type: Bug
I haven't seen this reported anywhere, so here goes.
Using the latest insiders version on macOS, I noticed that there are stability issues with extensions.
After some time running vscode, the extension host either crashes and needs to be restarted, or the code actions that trigger on saving a document start hanging.
I noticed that in the Developer Tools it frequently logs messages like:
The EFAULT exceptions might be triggering this behavior.
This also hangs and spins forever:
If I cancel it, then run
Developer: Restart Extension Host
it will then save properly.(It's possible one of my extensions might be interfering as well, as I have a ton of them enabled - but I don't remember seeing this on Stable VSCode with Rosetta.)
VS Code version: Code - Insiders 1.53.0-insider (4a875e2, 2020-12-21T12:34:09.548Z)
OS version: Darwin arm64 20.2.0
System Info
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Extensions (58)
(2 theme extensions excluded)
A/B Experiments
The text was updated successfully, but these errors were encountered: