Remote Launch from SSH don't work on 1.51 #110253

bobaoapae · 2020-11-09T18:29:35Z

VSCode Version:1.51
OS Version: Windows 10 20h2

Version 1.51 Remote Start: https://prnt.sc/vg9tm2 (10 minutes waiting)
Version 1.50.1 Remote Start: https://prnt.sc/vg9wpp (work as expected)

Launch.json: https://prnt.sc/vg9vuw

Does this issue occur when all extensions are disabled?: Yes

roblourens · 2020-11-09T19:32:47Z

Need more details, but please file an issue on the repo for the debug extension that you are using. You can also check developer tools (Help > Toggle Developer Tools) for possible errors.

bobaoapae · 2020-11-11T16:28:59Z

This only happen on version 1.51, downgrade to 1.50.1 fix this issue

bobaoapae · 2020-11-11T16:32:13Z

Developer Tools Log:

ERR Cannot read property 'scheme' of null: TypeError: Cannot read property 'scheme' of null
    at Object.transformIncoming (c:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\uriTransformer.js:4:76)
    at t.URITransformer.transformIncoming (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:244:220)
    at I._createTerminalProcess (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:781:351)
    at I.call (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:780:328)
    at x.onPromise (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:266:142)
    at x.onRawMessage (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:265:615)
    at C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:264:877
    at l.fire (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:48:801)
    at v.fire (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:281:381)
    at t.PersistentProtocol._receiveMessage (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:286:451)
    at C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:283:489
    at l.fire (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:48:801)
    at f.acceptChunk (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:278:851)
    at C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:278:203
    at Socket.t (C:\Users\Administrador\.vscode-server\bin\fcac248b077b55bae4ba5bab613fd6e9156c2f0c\out\vs\server\remoteExtensionHostAgent.js:288:226)
    at Socket.emit (events.js:223:5)
    at addChunk (_stream_readable.js:309:12)
    at readableAddChunk (_stream_readable.js:290:11)
    at Socket.Readable.push (_stream_readable.js:224:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:181:23)

roblourens · 2020-11-11T17:42:56Z

Does a normal terminal work? Does that error only show up when you click the button to start debugging?

bobaoapae · 2020-11-11T18:13:33Z

Normal terminal works, even the build task work, only remote start hangs forever. Yes this error show only when i click the button to start

roblourens · 2020-11-11T18:51:31Z

Does setting "terminal.integrated.serverSpawn": false fix it?

roblourens · 2020-11-11T18:54:32Z

@alexdima seems that we have args.shellLaunchConfig.cwd as null, when we only check for undefined

roblourens · 2020-11-11T19:06:14Z

I can repro this just with vscode.window.createTerminal({ cwd: null, name: 'extension terminal' }); in a remote extension

roblourens · 2020-11-11T19:26:21Z

Can you share your launch config too @bobaoapae?

bobaoapae · 2020-11-11T19:44:57Z

Can you share your launch config too @bobaoapae?

{
    // Use IntelliSense to find out which attributes exist for C# debugging
    // Use hover for the description of the existing attributes
    // For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Center Service",
            "type": "coreclr",
            "preLaunchTask": "build",
            "request": "launch",
            // If you have changed target frameworks, make sure to update the program path.
            "program": "${workspaceFolder}/Center.Service/bin/Debug/netcoreapp3.1/win10-x64/Center.Service.dll",
            "args": [],
            "cwd": "${workspaceFolder}/Center.Service/bin/Debug/netcoreapp3.1/win10-x64/",
            // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console
            "console": "integratedTerminal",
            "stopAtEntry": false,
            "allowFastEvaluate": true
        },
        {
            "name": "Fight Service",
            "type": "coreclr",
            "preLaunchTask": "build",
            "request": "launch",
            // If you have changed target frameworks, make sure to update the program path.
            "program": "${workspaceFolder}/Fighting.Service/bin/Debug/netcoreapp3.1/win10-x64/Fighting.Service.dll",
            "args": [],
            "cwd": "${workspaceFolder}/Fighting.Service/bin/Debug/netcoreapp3.1/win10-x64/",
            // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console
            "console": "integratedTerminal",
            "stopAtEntry": false,
            "allowFastEvaluate": true
        },
        {
            "name": "Flash Service",
            "type": "coreclr",
            "preLaunchTask": "build",
            "request": "launch",
            // If you have changed target frameworks, make sure to update the program path.
            "program": "${workspaceFolder}/Flash.Service/bin/Debug/netcoreapp3.1/win10-x64/Flash.Service.dll",
            "args": [],
            "cwd": "${workspaceFolder}/Flash.Service/bin/Debug/netcoreapp3.1/win10-x64/",
            // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console
            "console": "integratedTerminal",
            "stopAtEntry": false,
            "allowFastEvaluate": true
        },
        {
            "name": "Game Service",
            "type": "coreclr",
            "preLaunchTask": "build",
            "request": "launch",
            // If you have changed target frameworks, make sure to update the program path.
            "program": "${workspaceFolder}/Game.Service/bin/Debug/netcoreapp3.1/win10-x64/Game.Service.dll",
            "args": [],
            "cwd": "${workspaceFolder}/Game.Service/bin/Debug/netcoreapp3.1/win10-x64/",
            // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console
            "console": "integratedTerminal",
            "stopAtEntry": false,
            "allowFastEvaluate": true
        }
    ],
    "compounds": [
        {
            "name": "Debug All",
            "configurations": [
                "Center Service",
                "Fight Service",
                "Flash Service",
                "Game Service"
            ]
        }
    ]
}

bobaoapae · 2020-11-11T19:46:03Z

Does setting "terminal.integrated.serverSpawn": false fix it?

I need try, i cant update vscode to test right now, when i finish coding i will try this

alexdima · 2020-11-11T20:33:54Z

seems that we have args.shellLaunchConfig.cwd as null, when we only check for undefined

I see. This means that

vscode/src/vs/workbench/contrib/terminal/common/terminal.ts

Line 204 in 02f6319

cwd?: string | URI;

is incorrect and it should be cwd?: string | URI | null

bobaoapae · 2020-11-11T20:35:01Z

Does setting "terminal.integrated.serverSpawn": false fix it?

Yes, with this config i don't have issues on start debug

roblourens · 2020-11-11T20:47:57Z

If you don't have the right strict option set for your extension, you can always do that. We often don't validate arguments from extension api in code.

alexdima · 2020-11-17T21:53:36Z

@roblourens 👍 Thanks for the fix!

github-actions · 2020-11-17T23:19:09Z

This bug has been fixed in to the latest release of VS Code Insiders!

@bobaoapae, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version d19c7c5 of Insiders (today's or later - you can use Help: About in the command pallete to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

Fix #110253

Spongman · 2020-11-20T00:16:17Z

/verified

i was seeing this in 1.5.1 (when debugging c# on ubuntu wsl from windows), but not in

Version: 1.52.0-insider (user setup)
Commit: a36c68b
Date: 2020-11-19T05:37:52.577Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

meganrogge · 2020-12-04T18:54:17Z

/verified

per the above, adding z-author-verified label

vscode-triage-bot assigned weinand Nov 9, 2020

eamodio assigned roblourens and chrmarti and unassigned weinand Nov 9, 2020

roblourens closed this as completed Nov 9, 2020

bobaoapae mentioned this issue Nov 11, 2020

Launch hangs on Linux with integratedTerminal dotnet/vscode-csharp#4203

Closed

roblourens reopened this Nov 11, 2020

roblourens added the info-needed Issue requires more information from poster label Nov 11, 2020

roblourens unassigned chrmarti Nov 11, 2020

roblourens added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues and removed info-needed Issue requires more information from poster labels Nov 11, 2020

roblourens added this to the November 2020 milestone Nov 11, 2020

alexdima added the regression Something that used to work is now broken label Nov 11, 2020

alexdima self-assigned this Nov 11, 2020

alexdima added the remote Remote system operations issues label Nov 11, 2020

roblourens closed this as completed in af6843b Nov 15, 2020

roblourens added the author-verification-requested Issues potentially verifiable by issue author label Nov 17, 2020

meganrogge pushed a commit that referenced this issue Nov 18, 2020

Convert terminal ext api null args to undefined

2e6e479

Fix #110253

meganrogge added z-author-verified and removed author-verification-requested Issues potentially verifiable by issue author labels Dec 4, 2020

roblourens added the verified Verification succeeded label Dec 4, 2020

github-actions bot locked and limited conversation to collaborators Dec 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remote Launch from SSH don't work on 1.51 #110253

Remote Launch from SSH don't work on 1.51 #110253

bobaoapae commented Nov 9, 2020 •

edited

Loading

roblourens commented Nov 9, 2020

bobaoapae commented Nov 11, 2020

bobaoapae commented Nov 11, 2020 •

edited by roblourens

Loading

roblourens commented Nov 11, 2020

bobaoapae commented Nov 11, 2020 •

edited

Loading

roblourens commented Nov 11, 2020

roblourens commented Nov 11, 2020

roblourens commented Nov 11, 2020

roblourens commented Nov 11, 2020

bobaoapae commented Nov 11, 2020 •

edited by roblourens

Loading

bobaoapae commented Nov 11, 2020

alexdima commented Nov 11, 2020

bobaoapae commented Nov 11, 2020

roblourens commented Nov 11, 2020

alexdima commented Nov 17, 2020

github-actions bot commented Nov 17, 2020

Spongman commented Nov 20, 2020 •

edited

Loading

meganrogge commented Dec 4, 2020

Remote Launch from SSH don't work on 1.51 #110253

Remote Launch from SSH don't work on 1.51 #110253

Comments

bobaoapae commented Nov 9, 2020 • edited Loading

roblourens commented Nov 9, 2020

bobaoapae commented Nov 11, 2020

bobaoapae commented Nov 11, 2020 • edited by roblourens Loading

roblourens commented Nov 11, 2020

bobaoapae commented Nov 11, 2020 • edited Loading

roblourens commented Nov 11, 2020

roblourens commented Nov 11, 2020

roblourens commented Nov 11, 2020

roblourens commented Nov 11, 2020

bobaoapae commented Nov 11, 2020 • edited by roblourens Loading

bobaoapae commented Nov 11, 2020

alexdima commented Nov 11, 2020

bobaoapae commented Nov 11, 2020

roblourens commented Nov 11, 2020

alexdima commented Nov 17, 2020

github-actions bot commented Nov 17, 2020

Spongman commented Nov 20, 2020 • edited Loading

meganrogge commented Dec 4, 2020

bobaoapae commented Nov 9, 2020 •

edited

Loading

bobaoapae commented Nov 11, 2020 •

edited by roblourens

Loading

bobaoapae commented Nov 11, 2020 •

edited

Loading

bobaoapae commented Nov 11, 2020 •

edited by roblourens

Loading

Spongman commented Nov 20, 2020 •

edited

Loading