Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Find with Selection" no longer works with an empty selection #109756

Closed
adzenith opened this issue Oct 30, 2020 · 2 comments · Fixed by #109762
Closed

"Find with Selection" no longer works with an empty selection #109756

adzenith opened this issue Oct 30, 2020 · 2 comments · Fixed by #109762
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@adzenith
Copy link

  • VSCode Version:
    Version: 1.51.0-insider
    Commit: 2d8bbc6
    Date: 2020-10-30T05:55:22.238Z (13 hrs ago)
  • OS Version:
    macOS Catalina 10.15.4 (19E287)

Steps to Reproduce:

  1. Put the insertion point in the middle of a word
  2. Run "Find with selection" (either via keybinding or in the cmd+p menu)

Expected result (and how it's worked since as long as I've used VS Code): the find buffer is filled with the word containing the current insertion point when the selection is empty
Result as of I think yesterday: nothing happens

I use "Find with selection" about a million times a day (slight exaggeration, but only slight 😄) and I immediately noticed this change in behavior. For what it's worth, I used Sublime Text before VS Code and its "Find with selection" also works with an empty selection, so I have about a decade's worth of muscle memory here.

Does this issue occur when all extensions are disabled?
Presumably so, but:

$ code-insiders --disable-extensions
Ignoring option disable-extensions: not supported for code-insiders.
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations important Issue identified as high-priority regression Something that used to work is now broken labels Oct 30, 2020
@rebornix rebornix added this to the October 2020 milestone Oct 30, 2020
@rebornix
Copy link
Member

Thank you sir, good catch ❤️

rebornix added a commit that referenced this issue Oct 30, 2020
@rebornix rebornix removed regression Something that used to work is now broken unreleased Patch has not yet been released in VS Code Insiders labels Oct 30, 2020
@rebornix rebornix modified the milestones: October 2020, November 2020 Oct 30, 2020
@rebornix rebornix reopened this Oct 30, 2020
@adzenith
Copy link
Author

adzenith commented Nov 2, 2020

Thank you!! Such a fast fix :)

@rzhao271 rzhao271 added the verified Verification succeeded label Nov 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@adzenith @rebornix @rzhao271 and others