Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make auto attach toggle workspace settings by default #105883

Closed
connor4312 opened this issue Sep 1, 2020 · 1 comment · Fixed by #106521
Closed

Make auto attach toggle workspace settings by default #105883

connor4312 opened this issue Sep 1, 2020 · 1 comment · Fixed by #106521
Assignees
@connor4312
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Milestone
September 2020

Comments

@connor4312
Copy link
Member

Are you setting auto attach to "on" in your user settings? Note that the Toggle Auto Attach command will persist in the workspace setting by default.

Oh my. I find this a bit confusing. So if I manualy first set it in user settings you will always write it there, otherwise you would do this in the workspace settings - making the whole repository dirty. I am not a fan of automatic writing in workspace settings...

Originally posted by @isidorn in #105771 (comment)
@connor4312
Copy link
Member Author

connor4312 commented Sep 1, 2020 •
edited
Loading

Or, we can remove the command since quick access is no longer as necessary microsoft/vscode-js-debug#732 (comment)

@connor4312 connor4312 added the polish Cleanup and polish issue label Sep 1, 2020
@connor4312 connor4312 added this to the September 2020 milestone Sep 1, 2020
@connor4312 connor4312 self-assigned this Sep 1, 2020
connor4312 added a commit that referenced this issue Sep 11, 2020
@connor4312
debug: use only js-debug auto attach, collapse settings
575a3c9 
This PR removes the hook in node-debug's auto attach, and uses only
js-debug auto attach. As referenced in the linked issues, this involves
removing `debug.javascript.usePreviewAutoAttach` and collapsing
`debug.node.autoAttach` into `debug.javascript.autoAttachFilter`. The
latter option gains a new state: `disabled`. Since there's no runtime
cost to having auto attach around, there is now no distinct off versus
disabled state.

The status bar item and the `Debug: Toggle Auto Attach` command now
open a quickpick, which looks like this:

![](https://memes.peet.io/img/20-09-9d2b6c0a-8b3f-4481-b2df-0753c54ee02b.png)

The current setting value is selected in the quickpick. If there is a
workspace setting for auto attach, the quickpick toggle the setting
there by default. Otherwise (as in the image) it will target the user
settings. The targeting is more explicit and defaults to the user
instead of the workspace, which should help reduce confusion (#97087).
Selecting the "scope change" item will reopen the quickpick in that
location.

Aside from the extra options for the `disabled` state in js-debug's
contributions, there's no changes required to it or its interaction
with debug-auto-launch.

Side note: I really wanted a separator between the states and the
scope change item, but this is not possible from an extension #74967.

Fixes #105883
Fixes microsoft/vscode-js-debug#732 (the rest of it)
Fixes #105963
Fixes #97087
@connor4312 connor4312 mentioned this issue Sep 11, 2020
Merged
@kieferrm kieferrm mentioned this issue Sep 14, 2020
Closed
41 tasks
sandy081 pushed a commit that referenced this issue Sep 16, 2020
@connor4312 @sandy081
debug: use only js-debug auto attach, collapse settings
cec4968 
This PR removes the hook in node-debug's auto attach, and uses only
js-debug auto attach. As referenced in the linked issues, this involves
removing `debug.javascript.usePreviewAutoAttach` and collapsing
`debug.node.autoAttach` into `debug.javascript.autoAttachFilter`. The
latter option gains a new state: `disabled`. Since there's no runtime
cost to having auto attach around, there is now no distinct off versus
disabled state.

The status bar item and the `Debug: Toggle Auto Attach` command now
open a quickpick, which looks like this:

![](https://memes.peet.io/img/20-09-9d2b6c0a-8b3f-4481-b2df-0753c54ee02b.png)

The current setting value is selected in the quickpick. If there is a
workspace setting for auto attach, the quickpick toggle the setting
there by default. Otherwise (as in the image) it will target the user
settings. The targeting is more explicit and defaults to the user
instead of the workspace, which should help reduce confusion (#97087).
Selecting the "scope change" item will reopen the quickpick in that
location.

Aside from the extra options for the `disabled` state in js-debug's
contributions, there's no changes required to it or its interaction
with debug-auto-launch.

Side note: I really wanted a separator between the states and the
scope change item, but this is not possible from an extension #74967.

Fixes #105883
Fixes microsoft/vscode-js-debug#732 (the rest of it)
Fixes #105963
Fixes #97087
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Milestone
September 2020
Development

Successfully merging a pull request may close this issue.

debug: use only js-debug auto attach, collapse settings microsoft/vscode
2 participants
@connor4312 and others