Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable paths in terminal window to be clickable as 'reveal in explorer' #102638

Closed
johndog opened this issue Jul 15, 2020 · 5 comments
Closed

Enable paths in terminal window to be clickable as 'reveal in explorer' #102638

johndog opened this issue Jul 15, 2020 · 5 comments
Assignees
Labels
*extension-candidate Issue identified as good extension implementation feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label terminal-links
Milestone

Comments

@johndog
Copy link

johndog commented Jul 15, 2020

If I'm using powershell and/or pester in a vscode terminal pane, often the results will result in files and folder paths being displayed. It is usually possible to navigate to file and folder paths that are logged there with control click, which opens the file/folder in vscode. This request is to make it also possible to reveal the folder or file in File Explorer.

Current result of hovering over a folder like "C:\repos" is to show a tooltip:

image

@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2020

This is how it works already, provided that the folder is a in the explorer?

image

This doesn't as node-pty is the opened folder:

image

@Tyriar Tyriar closed this as completed Jul 16, 2020
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Jul 16, 2020
@johndog
Copy link
Author

johndog commented Jul 16, 2020

@Tyriar That isn't what I'm talking about: "File Explorer" here is referring to "Windows File Explorer". For example, a picture of what you get if you right click a file in the Visual Code explorer:

image

The third menu option is "Reveal in File Explorer", which will do exactly what I'm referring to do. This request is mostly for folders that are not in the workspace, and which I don't want to open in another workspace, just browse in the external shell.

@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2020

Oh ok, this will be possible using extensions soon using the link provider API #91290. You can use it now but you need a flag to enable.

I'll keep this open as we can consider adding it when we support multiple actions on a single link.

@Tyriar Tyriar reopened this Jul 16, 2020
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label and removed *as-designed Described behavior is as designed labels Jul 16, 2020
@Tyriar Tyriar added this to the Backlog milestone Jul 16, 2020
@Tyriar
Copy link
Member

Tyriar commented Oct 12, 2021

Closing as an extension could be built to add these links now. We may add this to core eventually but that would depend on being able to present multiple link actions in the hover #97070

@Tyriar Tyriar added the *extension-candidate Issue identified as good extension implementation label Oct 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*extension-candidate Issue identified as good extension implementation feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label terminal-links
Projects
None yet
Development

No branches or pull requests

3 participants
@Tyriar @johndog and others