Encoding euckr does not exist anymore

[bpasero]

@gyzerok this seems to be a regression in the webpack version of iconv-lite, I am pushing a test now to review...

[bpasero]

Uncomment this line to see the failure:

vscode/src/vs/workbench/services/textfile/test/node/encoding/encoding.test.ts

Lines 410 to 412 in c212efa

	if (enc === 'euckr') {
	continue; // TODO@ben failing test for https://github.com/microsoft/vscode/issues/101847
	}

When I debug this I see the following exception for encodingExists:

TypeError: Cannot read property '63' of undefined

a (/Users/bpasero/Development/Microsoft/monaco/node_modules/iconv-lite-umd/lib/iconv-lite-umd.js:10)
a.getCodec (/Users/bpasero/Development/Microsoft/monaco/node_modules/iconv-lite-umd/lib/iconv-lite-umd.js:8)
a.encodingExists (/Users/bpasero/Development/Microsoft/monaco/node_modules/iconv-lite-umd/lib/iconv-lite-umd.js:8)
encodingExists (encoding.js:136)
await in encodingExists (async)
getEncodingForResource (textFileService.js:478)
getReadEncoding (textFileService.js:464)
overwriteEncoding (textFileService.js:80)
createDecoder (encoding.js:40)
await in createDecoder (async)
(anonymous) (encoding.js:74)
(anonymous) (stream.js:170)
flowData (stream.js:170)
resume (stream.js:56)
on (stream.js:122)
(anonymous) (encoding.js:61)
toDecodeStream (encoding.js:27)
doRead (textFileService.js:78)
await in doRead (async)
read (textFileService.js:54)
read (nativeTextFileService.js:28)
run (editorStatus.js:1116)
await in run (async)
triggerAndDisposeAction (actions.js:85)
await in triggerAndDisposeAction (async)
(anonymous) (actions.js:64)
invokeFunction (instantiationService.js:43)
_tryExecuteCommand (commandService.js:74)
(anonymous) (commandService.js:64)
Promise.then (async)
executeCommand (commandService.js:64)
executeCommand (statusbarPart.js:639)
(anonymous) (statusbarPart.js:594)

@gyzerok @ashtuchkin any clues?

[gyzerok]

@bpasero I can take a look tomorrow. Quick idea - this is because of cp949 exclusion.

I was trying to reduce the library size by removing what is not needed. It seems that euckr is part of cp949 and I missed it.

[bpasero]

@gyzerok ok thanks. one thought I had: it would maybe be good if iconv-lite-umd would run the test suite of iconv-lite somehow to validate things are working fine. Maybe reduced depending on what VSCode is using.

[bpasero]

@gyzerok I ended up simply doing this change which makes the test succeed:

microsoft/vscode-iconv-lite-umd@f4180d8

[dbaeumer]

Verified using the following steps:

• open this file: build/win32/i18n/Default.ko.isl
• in the status bar switch to encoding EUC-KR

Verify that encoding is picked