Fix parameter not being escaped

Fixes #49057
microsoft · May 30, 2018 · a7a4c6c · a7a4c6c
1 parent 8589b59
commit a7a4c6c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/extensions/typescript-language-features/src/features/jsDocCompletionProvider.ts b/extensions/typescript-language-features/src/features/jsDocCompletionProvider.ts
@@ -206,6 +206,7 @@ class TryCompleteJsDocCommand implements Command {
 export function templateToSnippet(template: string): SnippetString {
 	// TODO: use append placeholder
 	let snippetIndex = 1;
+	template = template.replace(/\$/g, '\\$');
 	template = template.replace(/^\s*(?=(\/|[ ]\*))/gm, '');
 	template = template.replace(/^(\/\*\*\s*\*[ ]*)$/m, (x) => x + `\$0`);
 	template = template.replace(/\* @param([ ]\{\S+\})?\s+(\S+)\s*$/gm, (_param, type, post) => {

diff --git a/extensions/typescript-language-features/src/test/jsdocSnippet.test.ts b/extensions/typescript-language-features/src/test/jsdocSnippet.test.ts
@@ -70,7 +70,7 @@ suite('typescript.jsDocSnippet', () => {
 			[
 				'/**',
 				' * $0',
-				' * @param $arg ${1}',
+				' * @param \\$arg ${1}',
 				' */'
 			].join('\n'));
 	});