Skip to content

Commit

Permalink
Just kidding, keep proposed onDidChangeAuthenticationProviders API fo…
Browse files Browse the repository at this point in the history
…r now
  • Loading branch information
Rachel Macfarlane committed Jan 5, 2021
1 parent 942c3ba commit 4d8895c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 16 deletions.
6 changes: 6 additions & 0 deletions src/vs/vscode.proposed.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ declare module 'vscode' {
*/
export function registerAuthenticationProvider(provider: AuthenticationProvider): Disposable;

/**
* @deprecated - getSession should now trigger extension activation.
* Fires with the provider id that was registered or unregistered.
*/
export const onDidChangeAuthenticationProviders: Event<AuthenticationProvidersChangeEvent>;

/**
* An array of the information of authentication providers that are currently registered.
*/
Expand Down
8 changes: 0 additions & 8 deletions src/vs/workbench/api/common/extHost.api.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,14 +219,6 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
checkProposedApiEnabled(extension);
return extHostAuthentication.onDidChangeAuthenticationProviders;
},
getProviderIds(): Thenable<ReadonlyArray<string>> {
checkProposedApiEnabled(extension);
return extHostAuthentication.getProviderIds();
},
get providerIds(): string[] {
checkProposedApiEnabled(extension);
return extHostAuthentication.providerIds;
},
get providers(): ReadonlyArray<vscode.AuthenticationProviderInformation> {
checkProposedApiEnabled(extension);
return extHostAuthentication.providers;
Expand Down
8 changes: 0 additions & 8 deletions src/vs/workbench/api/common/extHostAuthentication.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,6 @@ export class ExtHostAuthentication implements ExtHostAuthenticationShape {
return Promise.resolve();
}

getProviderIds(): Promise<ReadonlyArray<string>> {
return this._proxy.$getProviderIds();
}

get providerIds(): string[] {
return this._providerIds;
}

get providers(): ReadonlyArray<vscode.AuthenticationProviderInformation> {
return Object.freeze(this._providers.slice());
}
Expand Down

0 comments on commit 4d8895c

Please sign in to comment.