Several CJK strings on the UI are very difficult to read on standard …

…definition monitors due to font weight and size (fixes #8653)
microsoft · Jul 14, 2016 · 3544dc9 · 3544dc9
1 parent 1cef0f3
commit 3544dc9
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 22 deletions.
diff --git a/src/vs/base/browser/ui/inputbox/inputBox.css b/src/vs/base/browser/ui/inputbox/inputBox.css
@@ -18,12 +18,6 @@
 	font-size: inherit;
 }
 
-/*.monaco-inputbox { font-family: "Segoe UI", ".SFNSDisplay-Light", "SFUIText-Light", "HelveticaNeue-Light", sans-serif, "Droid Sans Fallback"; }
-.monaco-inputbox:lang(zh-Hans) { font-family: "Segoe UI", ".SFNSDisplay-Light", "SFUIText-Light", "HelveticaNeue-Light", "Noto Sans", "Microsoft YaHei", "PingFang SC", "Hiragino Sans GB", "Source Han Sans SC", "Source Han Sans CN", "Source Han Sans", sans-serif; }
-.monaco-inputbox:lang(zh-Hant) { font-family: "Segoe UI", ".SFNSDisplay-Light", "SFUIText-Light", "HelveticaNeue-Light", "Noto Sans", "Microsoft Jhenghei", "PingFang TC", "Source Han Sans TC", "Source Han Sans", "Source Han Sans TW", sans-serif; }
-.monaco-inputbox:lang(ja) { font-family: "Segoe UI", ".SFNSDisplay-Light", "SFUIText-Light", "HelveticaNeue-Light", "Noto Sans", "Meiryo", "Hiragino Kaku Gothic Pro", "Source Han Sans J", "Source Han Sans JP", "Source Han Sans", "Sazanami Gothic", "IPA Gothic", sans-serif; }
-.monaco-inputbox:lang(ko) { font-family: "Segoe UI", ".SFNSDisplay-Light", "SFUIText-Light", "HelveticaNeue-Light", "Noto Sans", "Malgun Gothic", "Nanum Gothic", "Dotom", "Apple SD Gothic Neo", "AppleGothic", "Source Han Sans K", "Source Han Sans JR", "Source Han Sans", "UnDotum", "FBaekmuk Gulim", sans-serif; }*/
-
 .monaco-inputbox > .wrapper > .input,
 .monaco-inputbox > .wrapper > .mirror {
 

diff --git a/src/vs/base/browser/ui/splitview/splitview.css b/src/vs/base/browser/ui/splitview/splitview.css
@@ -31,6 +31,12 @@
 	display: flex;
 }
 
+/* Bold font style does not go well with CJK fonts */
+.monaco-split-view:lang(zh-Hans) > .split-view-view > .header,
+.monaco-split-view:lang(zh-Hant) > .split-view-view > .header,
+.monaco-split-view:lang(ja) > .split-view-view > .header,
+.monaco-split-view:lang(ko) > .split-view-view > .header { font-weight: normal; }
+
 .monaco-split-view > .split-view-view > .header.collapsible {
 	cursor: pointer;
 }

diff --git a/src/vs/workbench/electron-browser/media/shell.css b/src/vs/workbench/electron-browser/media/shell.css
@@ -196,10 +196,6 @@
 	text-decoration: underline;
 }
 
-.monaco-shell a.strong {
-	font-weight: bold;
-}
-
 a:active {
 	color: inherit;
 	background-color: inherit;
@@ -233,18 +229,6 @@ a:active {
 	border-bottom: 5px solid white;
 }
 
-.monaco-shell .context-view .monaco-menu .actions-container {
-	min-width: 160px;
-}
-
-.monaco-shell .monaco-menu .action-label.check {
-	font-weight: bold;
-}
-
-.monaco-shell .monaco-menu .action-label.uncheck {
-	font-weight: normal;
-}
-
 .monaco-shell input:disabled {
 	background-color: #E1E1E1;
 }

diff --git a/src/vs/workbench/parts/files/browser/media/explorerviewlet.css b/src/vs/workbench/parts/files/browser/media/explorerviewlet.css
@@ -93,6 +93,12 @@
 	cursor: default;
 }
 
+/* Bold font style does not go well with CJK fonts */
+.explorer-viewlet:lang(zh-Hans) .explorer-open-editors .monaco-tree .monaco-tree-row .editor-group,
+.explorer-viewlet:lang(zh-Hant) .explorer-open-editors .monaco-tree .monaco-tree-row .editor-group,
+.explorer-viewlet:lang(ja) .explorer-open-editors .monaco-tree .monaco-tree-row .editor-group,
+.explorer-viewlet:lang(ko) .explorer-open-editors .monaco-tree .monaco-tree-row .editor-group { font-weight: normal; }
+
 /* Disable tree twistie */
 .explorer-viewlet .explorer-open-editors > .monaco-tree .monaco-tree-rows > .monaco-tree-row > .content:after,
 .explorer-viewlet .explorer-open-editors > .monaco-tree .monaco-tree-rows > .monaco-tree-row > .content:before {

diff --git a/src/vs/workbench/parts/git/browser/views/changes/changesView.css b/src/vs/workbench/parts/git/browser/views/changes/changesView.css
@@ -69,6 +69,12 @@
 	cursor: default;
 }
 
+/* Bold font style does not go well with CJK fonts */
+.git-viewlet:lang(zh-Hans) > .changes-view > .status-view > .monaco-tree .monaco-tree-row .status-group,
+.git-viewlet:lang(zh-Hant) > .changes-view > .status-view > .monaco-tree .monaco-tree-row .status-group,
+.git-viewlet:lang(ja) > .changes-view > .status-view > .monaco-tree .monaco-tree-row .status-group,
+.git-viewlet:lang(ko) > .changes-view > .status-view > .monaco-tree .monaco-tree-row .status-group { font-weight: normal; }
+
 .git-viewlet > .changes-view > .status-view > .monaco-tree .monaco-tree-row .count-badge-wrapper {
 	padding-right: 12px;
 }