Fix optional insert text completions

Fixes microsoft/TypeScript#22125
microsoft · Mar 13, 2018 · 2678fff · 2678fff
1 parent dec9d8f
commit 2678fff
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/extensions/typescript/src/features/completionItemProvider.ts b/extensions/typescript/src/features/completionItemProvider.ts
@@ -71,8 +71,13 @@ class MyCompletionItem extends vscode.CompletionItem {
 		}
 
 		if (tsEntry.kindModifiers && tsEntry.kindModifiers.match(/\boptional\b/)) {
-			this.insertText = this.label;
-			this.filterText = this.label;
+			if (!this.insertText) {
+				this.insertText = this.label;
+			}
+
+			if (!this.filterText) {
+				this.filterText = this.label;
+			}
 			this.label += '?';
 		}
 	}