Skip to content

Commit

Permalink
limit error notifications in macos update service (#182269)
Browse files Browse the repository at this point in the history
fixes #182250
  • Loading branch information
joaomoreno authored May 12, 2023
1 parent 5860847 commit 0ca6d0f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/vs/platform/update/electron-main/updateService.darwin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ export class DarwinUpdateService extends AbstractUpdateService {
this.logService.error('UpdateService error:', err);

// only show message when explicitly checking for updates
const shouldShowMessage = this.state.type === StateType.CheckingForUpdates ? this.state.explicit : true;
const message: string | undefined = shouldShowMessage ? err : undefined;
const message = (this.state.type === StateType.CheckingForUpdates && this.state.explicit) ? err : undefined;
this.setState(State.Idle(UpdateType.Archive, message));
}

Expand Down

0 comments on commit 0ca6d0f

Please sign in to comment.