Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .vscodeignore not working #577

Closed
wants to merge 1 commit into from

Conversation

fyangstudio
Copy link

#576

Update ignore usage:

ignore()
.add(fs.readFileSync(filenameOfGitignore).toString())
.filter(filenames)

see: https://www.npmjs.com/package/ignore

@ghost
Copy link

ghost commented Jun 7, 2021

CLA assistant check
All CLA requirements met.

@joaomoreno
Copy link
Member

This doesn't change anything at all besides using sync Node API.

@joaomoreno joaomoreno closed this Jun 7, 2021
@fyangstudio fyangstudio deleted the fix-ignore-file branch June 7, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants