Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warns the extension authors of extensionKind type change #404

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Warns the extension authors of extensionKind type change #404

merged 1 commit into from
Dec 2, 2019

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Nov 30, 2019 •
edited
Loading

Fixes #403

@sandy081:

  • This currently only emits a warning, doesn't prevent publishing... should it?
  • I believe we need a better user facing message, maybe with a better link describing the adoption and the purpose of that property.

@sandy081
Copy link
Member

sandy081 commented Dec 1, 2019

Here is the link to the documentation - https://code.visualstudio.com/api/advanced-topics/remote-extensions#incorrect-execution-location

May be we should show this link.

Warning is good enough I think.

@joaomoreno
Copy link
Member Author

Created https://aka.ms/vscode/api/incorrect-execution-location for it.

Left the warning.

@joaomoreno joaomoreno merged commit facdf0a into master Dec 2, 2019
@joaomoreno joaomoreno deleted the pr/fix-403 branch December 2, 2019 08:54
@joaomoreno
Copy link
Member Author

Coming out in 1.70.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate extensions having string value for extension kind while publishing
2 participants
@joaomoreno @sandy081