Support the files property in package.json

[lorensr]

Currently, vsce ls ignores my files allowlist, which means the only way to configure which files are published is with the .vscodeignore denylist. Allowlists are safer and more maintainable than denylists, and files is the standard in the ecosystem. #12 is an older version of this feature request, and includes 15 upvotes for the workaround, which no longer works.

[joaomoreno]

Sounds good. I suggest the following:

• If no .vscodeignore file exists, the files property can be respected.
• Otherwise, .vscodeignore is always respected.

[JacksonTian]

The .vscodeignore is blocklist, the files is allowlist.

[ghost]

I'd like to take this up @joaomoreno.

A minimal fix for this could be adding a allowlist parameter to the collectAllFiles function at

vscode-vsce/src/package.ts

Line 1567 in 6e959ca

async function collectAllFiles(

i.e. if there exists a files property in the manifest then we filter out the output of the collectAllFiles function to only contain files from the allowlist. Would appreciate the guidance of the community on this.

[vanyauhalin]

@benibenj, thank you! Could you please let us know when we might be able to start using this?

[benibenj]

@vanyauhalin We just released a new version which includes the change

[benibenj]

@vanyauhalin Have you adopted the files property already? If so, can you confirm it works as intended?

[vanyauhalin]

@benibenj Apologize for the delayed response. Works perfectly. Thank you.