fix: compile with node 20, test with 16 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
force-pushed
the
connor4312/use-modern-compile
branch
3 times, most recently
from
28b6e8c
to
5b6a863
Compare
Fixes compatibility issues with version bumps in the last PR. We're good to use Node 20 to lint and such, just switch to the min version (16) for running tests. This is needed to publish.
connor4312
force-pushed
the
connor4312/use-modern-compile
branch
from
5b6a863
to
099cf41
Compare
rzhao271
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compatibility issues with version bumps in the last PR. We're good to use Node 20 to lint and such, just switch to the min version (16) for running tests. This is needed to publish.