Clarification on the extensionTestsPath run signature

[JustinGrote]

The help specifies this:

	 * Must export a `run` function of the following signature:
	 *
	 * ```ts
	 * function run(): Promise<void>;
	 * ```

But the samples entrypoints have parameters:

vscode-test/sample/src/test/suite/index.ts

Line 5 in addc23e

export function run(testsRoot: string, cb: (error: any, failures?: number) => void): void {

When I try this myself, the first param gets populated with the name of the test file that was called (not the "root" as the line proposes), and the callback seems to be null. Is the help out of date or am I missing something?

CC @connor4312

[connor4312]

The second argument should definitely be there. This is where it gets called:

https://github.com/microsoft/vscode/blob/b45aed4afc4f716b18a849c420e67211eaea8b87/src/vs/workbench/api/common/extHostExtensionService.ts#L736

I see that when run() gets called as well. I will update docs. Though it seems like passing the path is kind of useless 🤷

[JustinGrote]

@connor4312 confirmed that the cb does exist, for some reason it wasn't evaluating right. Thanks! And yeah the testsRoot is pretty useless since you can just get it from execpath.

I also see it is noted there as the "old" API, looks like this is just there for compatibility, so either method is supported, thanks for finding the hook.

[connor4312]

Yea, we have the callback from the pre-promises era. People should not really be using that for new code, so I don't want to document people.