Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize Activate.ps1 #9911

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

brettcannon
Copy link
Member

For #2607

This is to allow Activate.ps1 to work appropriate on Linux for PowerShell Core.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #9911 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9911   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files         564      564           
  Lines       30061    30061           
  Branches     4545     4545           
=======================================
  Hits        18403    18403           
  Misses      10629    10629           
  Partials     1029     1029
Impacted Files Coverage Δ
...al/environmentActivationProviders/commandPrompt.ts 92.85% <100%> (ø) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f551a73...78c1568. Read the comment docs.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brettcannon brettcannon merged commit 21b7694 into microsoft:master Feb 5, 2020
@brettcannon brettcannon deleted the capitalize-Activate branch February 5, 2020 21:01
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants