Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use activated python proc to check if modules are installed #9644

Merged
merged 6 commits into from
Jan 17, 2020

Conversation

DonJayamanne
Copy link

For #9643

@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #9644 into master will increase coverage by 0.05%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9644      +/-   ##
==========================================
+ Coverage   60.64%   60.69%   +0.05%     
==========================================
  Files         547      547              
  Lines       29541    29553      +12     
  Branches     4467     4471       +4     
==========================================
+ Hits        17914    17937      +23     
+ Misses      10629    10614      -15     
- Partials      998     1002       +4
Impacted Files Coverage Δ
src/client/common/process/types.ts 100% <ø> (ø) ⬆️
...lient/datascience/jupyter/kernels/kernelService.ts 50.58% <100%> (ø) ⬆️
...rc/client/common/process/pythonExecutionFactory.ts 97.53% <100%> (ø) ⬆️
src/client/common/installer/productInstaller.ts 95.85% <50%> (ø) ⬆️
...interpreter/jupyterInterpreterDependencyService.ts 66.05% <0%> (-3.18%) ⬇️
...er/jupyterInterpreterSubCommandExecutionService.ts 83.19% <0%> (-0.81%) ⬇️
src/client/common/utils/localize.ts 95.05% <0%> (+0.01%) ⬆️
...rc/client/datascience/jupyter/jupyterConnection.ts 83.18% <0%> (+16.51%) ⬆️
.../client/datascience/jupyter/jupyterConnectError.ts 75% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef6489...dd7b433. Read the comment docs.

rchiodo
rchiodo previously approved these changes Jan 17, 2020
@DonJayamanne
Copy link
Author

@rchiodo @IanMatthewHuff Please re-review

@rchiodo rchiodo dismissed their stale review January 17, 2020 22:04

revoking review

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nit

const activatedProcPromise = this.createActivatedEnvironment({
allowEnvironmentFetchExceptions: true,
pythonPath: pythonPath,
interpreter: interpreter,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rchiodo @IanMatthewHuff This is where the problem was.
We were passing pythonPath and that wasn't being used. Hence we reverted to using resrouce which pointed to the local interpreter.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit 97bad7d into microsoft:master Jan 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2020
@DonJayamanne DonJayamanne deleted the useActivatedEnv branch January 28, 2020 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants