-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use activated python proc to check if modules are installed #9644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9644 +/- ##
==========================================
+ Coverage 60.64% 60.69% +0.05%
==========================================
Files 547 547
Lines 29541 29553 +12
Branches 4467 4471 +4
==========================================
+ Hits 17914 17937 +23
+ Misses 10629 10614 -15
- Partials 998 1002 +4
Continue to review full report at Codecov.
|
@rchiodo @IanMatthewHuff Please re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with nit
const activatedProcPromise = this.createActivatedEnvironment({ | ||
allowEnvironmentFetchExceptions: true, | ||
pythonPath: pythonPath, | ||
interpreter: interpreter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rchiodo @IanMatthewHuff This is where the problem was.
We were passing pythonPath
and that wasn't being used. Hence we reverted to using resrouce
which pointed to the local interpreter.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
For #9643