Fix Microsoft/ptvsd#78 #960
Conversation
Wait for `process` event before requesting pause. Increase timeouts when waiting for `process` and `thread`, due to pydevd delay in thread reporting.
|
Counterpart to microsoft/ptvsd#179 |
| @@ -376,14 +377,11 @@ const EXPERIMENTAL_DEBUG_ADAPTER = path.join(__dirname, '..', '..', 'client', 'd | |||
| await debugClient.assertStoppedLocation('step', printLocation); | |||
| }); | |||
| test('Test pausing', async function () { | |||
| if (debuggerType !== 'python') { | |||
There was a problem hiding this comment.
Please restore this check.
Currently pausing does not work with the old debugger,
With the new debugger, it will not work again as PTVSD is not available on CI server.
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
- Coverage 64.01% 64.01% -0.01%
==========================================
Files 260 260
Lines 12028 12027 -1
Branches 2131 2130 -1
==========================================
- Hits 7700 7699 -1
Misses 4319 4319
Partials 9 9
Continue to review full report at Codecov.
|
| @@ -379,11 +380,12 @@ const EXPERIMENTAL_DEBUG_ADAPTER = path.join(__dirname, '..', '..', 'client', 'd | |||
| if (debuggerType !== 'python') { | |||
There was a problem hiding this comment.
Hi @int19h
Please skip this test unconditionally.
The old debugger doesn't send process event, and the new debugger cannot be run on CI.
Thanks, this is the only test that's failing on CI.
Wait for
processevent before requesting pause.Increase timeouts when waiting for
processandthread, due to pydevd delay in thread reporting.