Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented prompt for survey using A/B test framework #7090

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Aug 23, 2019

For #6957

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #7090 into master will increase coverage by 0.71%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7090      +/-   ##
==========================================
+ Coverage   57.67%   58.39%   +0.71%     
==========================================
  Files         483      483              
  Lines       21025    21414     +389     
  Branches     3446     3465      +19     
==========================================
+ Hits        12127    12504     +377     
- Misses       8124     8141      +17     
+ Partials      774      769       -5
Impacted Files Coverage Δ
src/client/activation/extensionSurvey.ts 98.11% <100%> (+0.19%) ⬆️
src/client/common/experimentGroups.ts 100% <100%> (ø) ⬆️
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️
src/client/linters/baseLinter.ts 80.34% <0%> (-1.37%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (ø) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/variables/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/process/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7ab99...89a270f. Read the comment docs.

@karrtikr karrtikr closed this Aug 25, 2019
@karrtikr karrtikr reopened this Aug 25, 2019
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karrtikr karrtikr merged commit 0640e82 into microsoft:master Aug 26, 2019
@karrtikr karrtikr deleted the surveyexperiment branch August 26, 2019 20:50
@lock lock bot locked as resolved and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants