Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for client/activation/serviceRegistry.ts #6587

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Jul 15, 2019

For #6163

Coverage went down(?) on client/common/logger.ts, issue to add unit tests here: #6099

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@kimadeline kimadeline marked this pull request as ready for review July 16, 2019 17:00
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why the coverage went down

@kimadeline
Copy link
Author

Yeah I don't understand either 🤷‍♀

The file I worked on now has 100% coverage:

image

But Coveralls says that the coverage in client/common/logger.ts went down, even though I didn't touch this file (Coveralls already knew it existed, we have an open issue to to add unit tests for it: #6099) 🤔

image

Oh well, thank you for the review 👍

@kimadeline kimadeline merged commit 7346377 into microsoft:master Jul 16, 2019
@kimadeline kimadeline deleted the 6163-activation-serviceRegistry-unittests branch July 16, 2019 18:39
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants