Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python.venvFolders settings #6035

Merged
merged 17 commits into from
Jun 18, 2019

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Jun 14, 2019

For #4642 and #118

  • Remove defaults from the python.venvFolders config setting (envs, .pyenv and .direnv) and hardcode them
  • Add defaults for pipenv and virtualenvwrapper
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@DonJayamanne
Copy link

@kimadeline Please ignore the failing CI

  • This is a flaky test (I thought I fixed it, looks like that didn't work)
  • If you encounter a flaky test, please disable the test, add an issue into GitHub with a label of P0, then continue with your PR.
  • Basically we don't want flaky tests to block other PRs..
  • Please could you disable the following (failing) tests (this it related to Flaky CI Tests #5085, something in the current sprint):
  • Again, all you need to do is, just disable this test in your PR.

Screen Shot 2019-06-14 at 15 00 44

@DonJayamanne
Copy link

Please include changes related to #118

@kimadeline kimadeline changed the title Update python.venvFolders settings WIP - Update python.venvFolders settings Jun 15, 2019
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes while this is in WIP...

src/test/common/utils/decorators.unit.test.ts Outdated Show resolved Hide resolved
src/test/common/utils/decorators.unit.test.ts Outdated Show resolved Hide resolved
src/test/common/utils/decorators.unit.test.ts Outdated Show resolved Hide resolved
src/test/interpreters/venv.unit.test.ts Outdated Show resolved Hide resolved
@kimadeline kimadeline changed the title WIP - Update python.venvFolders settings Update python.venvFolders settings Jun 17, 2019
@kimadeline kimadeline merged commit 30158f7 into microsoft:master Jun 18, 2019
@kimadeline kimadeline deleted the 4642-venvFolders branch June 28, 2019 16:40
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants