Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/ianhu/variable explorer styles #5106

Merged
merged 10 commits into from
Apr 4, 2019
Merged

Dev/ianhu/variable explorer styles #5106

merged 10 commits into from
Apr 4, 2019

Conversation

IanMatthewHuff
Copy link
Member

For #4998

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff requested a review from rchiodo April 3, 2019 22:16
rchiodo
rchiodo requested changes Apr 3, 2019
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@IanMatthewHuff IanMatthewHuff requested a review from rchiodo April 4, 2019 18:13
rchiodo
rchiodo approved these changes Apr 4, 2019
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@IanMatthewHuff IanMatthewHuff merged commit 16360da into microsoft:master Apr 4, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/variableExplorerStyles branch July 25, 2019 23:52
@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanMatthewHuff @rchiodo