Add ignore button to the MacInterpreterSelectedAndNoOtherInterpreters… #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Diagnostic diagnostic message to provide the ability to opt out of the warning. (Fixing related issue #4448)
Codecov Report
@@ Coverage Diff @@
## master #4808 +/- ##
========================================
- Coverage 77% 62% -14%
========================================
Files 450 373 -77
Lines 21707 14670 -7037
Branches 3573 1163 -2410
========================================
- Hits 16673 9074 -7599
- Misses 5030 5394 +364
- Partials 4 202 +198
|
DonJayamanne
approved these changes
Mar 18, 2019
|
Also, forgot to ask, looks like there are 2 diagnostic messages, and I was adding an Ignore button only to one of them as per the issue. But what about the other message, |
|
I'll add it. |
DonJayamanne
added a commit
that referenced
this pull request
Mar 29, 2019
* Update tpn distro and 3rd party notices * Pin to beta version of PTVSD (#4836) Update version of PTVSD * Add ignore button to the MacInterpreterSelectedAndNoOtherInterpreters… (#4808) Add ignore button to the MacInterpreterSelectedAndNoOtherInterpretersDiagnostic & MacInterpreterSelectedAndHaveOtherInterpretersDiagnostic diagnostic message to provide the ability to opt out of the warning. (Fixing related issue #4448) * Generalize test results service (#4813) * Generalize test results service * News entry * Fix gulp errors * Updated status icons * Added tests * fix names for run above and run below code lenses (#4879) * Fix multiline comments with text on first line. (#4884) * Cherry-pick 26a7b9c * cherry pick from master branch * Revert "Revert "Always use the same jedi environment (#4687)" (#4850)" This reverts commit 0268ef4. * Update change log entries * Bump ptvsd to 4.2.5 (#4904) * Bump version of PTVSD to 4.2.5 * Changes to capabilities * Ensure output panel does not steal focus due to ls errors (#4919) For #4868 <!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ --> - [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR) - [x] Title summarizes what is changing - [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!) - [n/a] Has sufficient logging. - [n/a] Has telemetry for enhancements. - [n/a] Unit tests & system/integration tests are added/updated - [n/a] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate - [n/a] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed) - [n/a] The wiki is updated with any design decisions/details. * Fix change log * Bump pinned version of Language Server * Release for march 2018 (#4931) * New version * Updated change log * Same logic for stable and beta (#4964) * Point release for March 2018 (#4965) * Capture telemetry when tests are disabled (#4997) For #4801 * Update change log
DonJayamanne
added a commit
that referenced
this pull request
Apr 4, 2019
* release: March 2019 point release with debugger fixes (#5056) Update change log Capture telemetry when tests are disabled (#4997) Point release for March 2018 (#4965) Same logic for stable and beta (#4964) Release for march 2018 (#4931) Bump pinned version of Language Server Fix change log Ensure output panel does not steal focus due to ls errors (#4919) Bump ptvsd to 4.2.5 (#4904) Update change log entries Revert "Revert "Always use the same jedi environment (#4687)" (#4850)" cherry pick from master branch Cherry-pick 26a7b9c Fix multiline comments with text on first line. (#4884) fix names for run above and run below code lenses (#4879) Generalize test results service (#4813) Add ignore button to the MacInterpreterSelectedAndNoOtherInterpreters… (#4808) Pin to beta version of PTVSD (#4836) Update tpn distro and 3rd party notices
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ignore button to the MacInterpreterSelectedAndNoOtherInterpretersDiagnostic diagnostic message to provide the ability to opt out of the warning. (Fixing related issue #4448)
For #4448
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)