Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PR validation Azure DevOps pipeline process. #4775

Merged
merged 9 commits into from
Mar 15, 2019

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Mar 15, 2019

For #4123

(Also for #3898, #4034, #4648, perhaps others)

Note: There will be a follow-up PR that will make the steps used inline in this process shared between PR + CI builds.


  • [no] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

d3r3kk added 7 commits March 15, 2019 11:55
- Make way for the new PR validation build def
- Update triggers to only be for CI
- documented
- simplified
- removed unnecessary tests for PR validation
- fix some unit tests
- also enable colour output on AzDO for system tests
- address PR suggestsions
  - Azure DevOps not Devops
  - Conditional missing on news tests
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

- conflicts with unittests apparently
@d3r3kk d3r3kk merged commit 3e99ea1 into microsoft:master Mar 15, 2019
@d3r3kk d3r3kk deleted the 4123_pr_validation_corrections branch March 15, 2019 21:34
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants