forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve PR validation Azure DevOps pipeline process. #4775
Merged
d3r3kk
merged 9 commits into
microsoft:master
from
d3r3kk:4123_pr_validation_corrections
Mar 15, 2019
Merged
Improve PR validation Azure DevOps pipeline process. #4775
d3r3kk
merged 9 commits into
microsoft:master
from
d3r3kk:4123_pr_validation_corrections
Mar 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make way for the new PR validation build def - Update triggers to only be for CI
- documented - simplified - removed unnecessary tests for PR validation - fix some unit tests
- also enable colour output on AzDO for system tests
brettcannon
reviewed
Mar 15, 2019
brettcannon
reviewed
Mar 15, 2019
brettcannon
approved these changes
Mar 15, 2019
- address PR suggestsions - Azure DevOps not Devops - Conditional missing on news tests
rchiodo
reviewed
Mar 15, 2019
rchiodo
requested changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
rchiodo
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- conflicts with unittests apparently
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4123
(Also for #3898, #4034, #4648, perhaps others)
Note: There will be a follow-up PR that will make the steps used inline in this process shared between PR + CI builds.
Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)Has a news entry file (remember to thank yourself!)Has telemetry for enhancements.Test plan is updated as appropriatepackage-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)The wiki is updated with any design decisions/details.