Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pipenv activation to not use pipenv shell #4406

Merged
merged 3 commits into from
Feb 15, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Feb 14, 2019

For #4394

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #4406 into master will increase coverage by 21%.
The diff coverage is 50%.

@@           Coverage Diff            @@
##           master   #4406     +/-   ##
========================================
+ Coverage      57%     78%    +21%     
========================================
  Files         364     439     +75     
  Lines       15495   20522   +5027     
  Branches     2408    3290    +882     
========================================
+ Hits         8752   15810   +7058     
+ Misses       6163    4708   -1455     
+ Partials      580       4    -576
Flag Coverage Δ
#Linux 66% <50%> (?)
#Windows 66% <50%> (?)
#macOS 66% <50%> (?)

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix compilation issues (see Azdo CI errors)

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI issues

@karrtikr karrtikr merged commit d30269b into microsoft:master Feb 15, 2019
@karrtikr karrtikr deleted the pipenv branch February 15, 2019 16:54
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants