Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localRoot & remoteRoot to the launch.json snippets #3950

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Jan 9, 2019

For #1385


  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

d3r3kk added 2 commits January 9, 2019 14:50
For microsoft#1385

- Will set localRoot to "${workspaceFolder}" by default
- Will set remoteRoot to "." by default
- PTVSD will (eventually) pick this up and infer "." to be CWD.
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #3950 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3950   +/-   ##
======================================
  Coverage      78%     78%           
======================================
  Files         402     402           
  Lines       18572   18572           
  Branches     2985    2985           
======================================
  Hits        14352   14352           
  Misses       4218    4218           
  Partials        2       2
Flag Coverage Δ
#Linux 68% <ø> (ø) ⬆️
#Windows 68% <ø> (ø) ⬆️
#macOS 68% <ø> (+1%) ⬆️
Impacted Files Coverage Δ
.../extension/configuration/providers/remoteAttach.ts 93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45d105...e6280b2. Read the comment docs.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tsk tsk tsk, changes to config alone resolved in a big drop of code coverage... 😁

resources/default.launch.json Outdated Show resolved Hide resolved
@d3r3kk d3r3kk changed the title WIP - Add localRoot & remoteRoot to the launch.json snippets Add localRoot & remoteRoot to the launch.json snippets Jan 10, 2019
@d3r3kk
Copy link
Author

d3r3kk commented Jan 10, 2019

@DonJayamanne code coverage + consistency. Now there is a failing functional test in CI though (unrelated).

Please have a quick look and let me know if I hit all the beats.

@d3r3kk
Copy link
Author

d3r3kk commented Jan 11, 2019

@DonJayamanne ping.

@d3r3kk d3r3kk added this to the 2019, week 3 - Jan Sprint 2 milestone Jan 17, 2019
resources/default.launch.json Outdated Show resolved Hide resolved
@d3r3kk d3r3kk merged commit bd1ee9f into microsoft:master Jan 22, 2019
@d3r3kk d3r3kk deleted the 1385_infer_remote_path branch January 22, 2019 18:55
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants