-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localRoot & remoteRoot to the launch.json snippets #3950
Conversation
For microsoft#1385 - Will set localRoot to "${workspaceFolder}" by default - Will set remoteRoot to "." by default - PTVSD will (eventually) pick this up and infer "." to be CWD.
Codecov Report
@@ Coverage Diff @@
## master #3950 +/- ##
======================================
Coverage 78% 78%
======================================
Files 402 402
Lines 18572 18572
Branches 2985 2985
======================================
Hits 14352 14352
Misses 4218 4218
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tsk tsk tsk, changes to config alone resolved in a big drop of code coverage... 😁
@DonJayamanne code coverage + consistency. Now there is a failing functional test in CI though (unrelated). Please have a quick look and let me know if I hit all the beats. |
@DonJayamanne ping. |
For #1385
Test plan is updated as appropriatepackage-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)