-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displayed actionable message when LS is not supported #3864
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3864 +/- ##
=======================================
+ Coverage 78% 81% +3%
=======================================
Files 401 400 -1
Lines 18516 18317 -199
Branches 2977 2953 -24
=======================================
+ Hits 14385 14740 +355
+ Misses 4129 3574 -555
- Partials 2 3 +1
Continue to review full report at Codecov.
|
556b0ab
to
ce16f5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One slight adjustment you could/should make and please follow up with @DonJayamanne on the injection thing, then you should be g2g!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other diagnostic files follow the same pattern (they do not inject messageService). Should I still do it?
Yes
Also, @karrtikr you need to fix the merge conflicts |
For #3634
Test plan is updated as appropriatepackage-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)