Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for discovering python interpreters on windows using py.exe #3783

Merged
merged 12 commits into from
Dec 22, 2018
Merged

Add support for discovering python interpreters on windows using py.exe #3783

merged 12 commits into from
Dec 22, 2018

Conversation

DonJayamanne
Copy link

For #3369

  • Depends on 3780
  • Add support for discovering python interpreters on windows using py.exe
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [no] Has a news entry file (remember to thank yourself!)
  • [no] Unit tests & system/integration tests are added/updated
  • [no] Test plan is updated as appropriate
  • [no] package-lock.json has been regenerated by running npm install (if dependencies have changed)

d3r3kk
d3r3kk approved these changes Dec 22, 2018
View reviewed changes
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Adding py to interpreter detection + the new delay/resolution you've put in place is very easy to understand and a nice touch.

Once #3780 goes through this is another welcome addition.

src/client/interpreter/interpreterService.ts Show resolved Hide resolved
src/client/interpreter/interpreterService.ts Show resolved Hide resolved
@DonJayamanne
Merge branch 'master' into issue3369Py.exe
acd7261 
* master:
  Remove `src/server` folder, as this is no longer required (#3782)
  Ensure configuration settings are retrieved using the ConfigurationService (#3780)
@DonJayamanne
fix code review comment
2ea4e57
@DonJayamanne
Fix compilation issue
e59d87c
@DonJayamanne DonJayamanne added the no-changelog No news entry required label Dec 22, 2018
@DonJayamanne DonJayamanne merged commit 7d419ed into microsoft:master Dec 22, 2018
@DonJayamanne DonJayamanne deleted the issue3369Py.exe branch May 24, 2019 20:23
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d3r3kk d3r3kk d3r3kk approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @d3r3kk