Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the downloaded Python language server nuget package filename. #2364

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Aug 9, 2018

Fixes #2362

  • Coincides with addition to CI/CD pipeline where we copy the latest bits to a static file name.

  • We need to use a specific name so we can just download it simply (going forward another scheme will be employed).

  • We want the bits to be updatable, easily, until we get to the release stage for the LS.

  • Title summarizes what is changing

  • Includes a news entry file (remember to thank yourself!)

  • Unit tests & code coverage are not adversely affected (within reason)

  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)

  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

Fixes microsoft#2362

- Coincides with addition to CI/CD pipeline
- CI/CD pipeline copies the latest bits to a static file name
- We need to use a specific name.
- We want the bits to be updatable.
- Until we ship non-beta python language server this will work.
@d3r3kk
Copy link
Author

d3r3kk commented Aug 9, 2018

@MikhailArkhipov please note that I re-built your build on the Language Server at the same commit as your build. Once this change is merged you can ask people to try the 'insiders build' of vscode-python and they can see the updated LS.

FYI: The Python-Language-Server That build now produces a static set of files called Python-Language-Server-[OS_type].beta.nupkg in addition to the Python-Language-Server-[OS_type].[Build_version].nupkg file now, in the 'old location'. You can see my change in the history of the build definition.

/cc: @zooba

@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #2364 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2364      +/-   ##
=========================================
- Coverage   76.03%     76%   -0.03%     
=========================================
  Files         309     309              
  Lines       14331   14331              
  Branches     2537    2537              
=========================================
- Hits        10896   10892       -4     
- Misses       3425    3429       +4     
  Partials       10      10
Flag Coverage Δ
#MacOS 74.19% <100%> (+0.02%) ⬆️
#Windows 74.31% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/client/activation/downloader.ts 35.36% <100%> (ø) ⬆️
src/client/unittests/display/main.ts 88.28% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cfc9d6...4a64648. Read the comment docs.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3r3kk d3r3kk merged commit 12b6a61 into microsoft:master Aug 9, 2018
@d3r3kk d3r3kk deleted the issue2362 branch August 9, 2018 22:25
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin language server version lock-in
2 participants