Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest LS protocol #2144

Closed
wants to merge 13 commits into from
Closed

Upgrade to latest LS protocol #2144

wants to merge 13 commits into from

Conversation

MikhailArkhipov
Copy link

@MikhailArkhipov MikhailArkhipov commented Jul 12, 2018

Upgrade to latest LS protocol since we need new CompletionItem field

Also
Fixes #2113
Fixes #2000

@d3r3kk
Copy link

d3r3kk commented Jul 12, 2018

Looks like this might need some npm update...

@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

Merging #2144 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2144      +/-   ##
==========================================
- Coverage   79.86%   79.49%   -0.37%     
==========================================
  Files         308      308              
  Lines       14176    14175       -1     
  Branches     2520     2520              
==========================================
- Hits        11321    11268      -53     
- Misses       2843     2895      +52     
  Partials       12       12
Flag Coverage Δ
#MacOS ?
#Windows ?
Impacted Files Coverage Δ
src/client/activation/languageServer.ts 26.13% <ø> (ø) ⬆️
src/client/activation/downloader.ts 25% <ø> (+0.28%) ⬆️
src/client/common/platform/registry.ts 40.42% <0%> (-51.07%) ⬇️
src/client/common/platform/pathUtils.ts 66.66% <0%> (-33.34%) ⬇️
src/client/common/utils.ts 51.51% <0%> (-21.22%) ⬇️
src/client/common/platform/serviceRegistry.ts 88.88% <0%> (-11.12%) ⬇️
src/client/common/platform/platformService.ts 84.21% <0%> (-5.27%) ⬇️
src/client/common/process/pythonProcess.ts 88.63% <0%> (-4.55%) ⬇️
src/client/interpreter/locators/index.ts 91.48% <0%> (-4.26%) ⬇️
src/client/refactor/proxy.ts 81.05% <0%> (-3.16%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07c5fb...bdce0ff. Read the comment docs.

@d3r3kk
Copy link

d3r3kk commented Jul 16, 2018

Completed the PR in #2164. Thanks Mikhail!

@d3r3kk d3r3kk closed this Jul 16, 2018
@MikhailArkhipov MikhailArkhipov deleted the watch branch September 13, 2018 01:30
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants