Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a glob pattern to look for conda executables #1904

Merged
merged 5 commits into from
Jun 8, 2018

Conversation

DonJayamanne
Copy link

Fixes #256

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #1904 into master will decrease coverage by 54.67%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1904       +/-   ##
===========================================
- Coverage   74.42%   19.74%   -54.68%     
===========================================
  Files         282      282               
  Lines       13260    13267        +7     
  Branches     2385     2386        +1     
===========================================
- Hits         9869     2620     -7249     
- Misses       3260    10647     +7387     
+ Partials      131        0      -131
Impacted Files Coverage Δ
src/client/common/platform/types.ts 100% <ø> (ø) ⬆️
...ient/interpreter/locators/services/condaService.ts 10.43% <33.33%> (-86.96%) ⬇️
src/client/common/platform/fileSystem.ts 33.76% <85.71%> (-31.95%) ⬇️
src/client/debugger/ProxyCommands.ts 0% <0%> (-100%) ⬇️
src/client/linters/linterInfo.ts 5.4% <0%> (-94.6%) ⬇️
src/client/language/tokenizer.ts 3.63% <0%> (-94.39%) ⬇️
src/client/common/process/proc.ts 6.97% <0%> (-93.03%) ⬇️
src/client/common/idDispenser.ts 7.14% <0%> (-92.86%) ⬇️
src/client/formatters/lineFormatter.ts 5.26% <0%> (-92.72%) ⬇️
src/client/language/characterStream.ts 4.41% <0%> (-91.18%) ⬇️
... and 226 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd46c26...ba80c87. Read the comment docs.

@d3r3kk d3r3kk closed this Jun 8, 2018
@d3r3kk
Copy link

d3r3kk commented Jun 8, 2018

What is the deal with VSTS...

@d3r3kk d3r3kk reopened this Jun 8, 2018
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work fine.

A side note: If our work causes a new dependency do we need to do anything special (as I've introduced a few new dev dependencies recently)

@DonJayamanne
Copy link
Author

DonJayamanne commented Jun 8, 2018

@d3r3kk
For normal dependencies create an issue and assign to Brett to do the necessary work with regards to licensing (CLA).
For dev dependencies, do nothing

@DonJayamanne DonJayamanne force-pushed the issue256 branch 4 times, most recently from 0b84783 to ee7374a Compare June 8, 2018 06:26
@DonJayamanne DonJayamanne merged commit 46fbca6 into microsoft:master Jun 8, 2018
@DonJayamanne DonJayamanne deleted the issue256 branch June 20, 2018 03:13
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use glob pattern to search for conda directories/files
2 participants