Skip to content

Remove MPLS survey #16901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 1 commit into from
Aug 9, 2021
Merged

Remove MPLS survey #16901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
"ExtensionSurveyBanner.bannerLabelYes": "Yes, take survey now",
"ExtensionSurveyBanner.bannerLabelNo": "No, thanks",
"ExtensionSurveyBanner.maybeLater": "Maybe later",
"ExtensionSurveyBanner.mplsMessage": "Can you please take 2 minutes to tell us about your experience using the Microsoft Python Language Server?",
"ExtensionChannels.installingInsidersMessage": "Installing Insiders... ",
"ExtensionChannels.installingStableMessage": "Installing Stable... ",
"ExtensionChannels.installationCompleteMessage": "complete.",
Expand Down
10 changes: 0 additions & 10 deletions src/client/activation/serviceRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,6 @@ import {
LanguageServerType,
} from './types';
import { JediLanguageServerActivator } from './jedi/activator';
import { IDiagnosticsService } from '../application/diagnostics/types';
import {
MPLSSurveyDiagnosticService,
MPLSSurveyDiagnosticServiceId,
} from '../application/diagnostics/checks/mplsSurvey';

export function registerTypes(serviceManager: IServiceManager, languageServerType: LanguageServerType): void {
serviceManager.addSingleton<ILanguageServerCache>(ILanguageServerCache, LanguageServerExtensionActivationService);
Expand Down Expand Up @@ -114,11 +109,6 @@ export function registerTypes(serviceManager: IServiceManager, languageServerTyp
DotNetLanguageServerPackageService,
);
registerDotNetTypes(serviceManager);
serviceManager.addSingleton<IDiagnosticsService>(
IDiagnosticsService,
MPLSSurveyDiagnosticService,
MPLSSurveyDiagnosticServiceId,
);
} else if (languageServerType === LanguageServerType.Node) {
serviceManager.add<ILanguageServerAnalysisOptions>(
ILanguageServerAnalysisOptions,
Expand Down
102 changes: 0 additions & 102 deletions src/client/application/diagnostics/checks/mplsSurvey.ts
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/client/common/utils/localize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,6 @@ export namespace ExtensionSurveyBanner {
export const bannerLabelYes = localize('ExtensionSurveyBanner.bannerLabelYes', 'Yes, take survey now');
export const bannerLabelNo = localize('ExtensionSurveyBanner.bannerLabelNo', 'No, thanks');
export const maybeLater = localize('ExtensionSurveyBanner.maybeLater', 'Maybe later');
export const mplsMessage = localize(
'ExtensionSurveyBanner.mplsMessage',
'Can you please take 2 minutes to tell us about your experience using the Microsoft Python Language Server?',
);
}

export namespace Products {
Expand Down
Loading