Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin py to 1.8.1 (CI failure - Windows unit tests) #12407

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Pin py to 1.8.1 (CI failure - Windows unit tests) #12407

merged 1 commit into from
Jun 18, 2020

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Jun 17, 2020 •
edited
Loading

For #12372

Will create a backlog item for fixing the pytest tests to not be dependent on pytest output: #12416

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Jun 17, 2020
@kimadeline kimadeline changed the title Pin py to 1.8.1 (Ci failure - Windows unit tests) Pin py to 1.8.1 (CI failure - Windows unit tests) Jun 17, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@kimadeline kimadeline marked this pull request as ready for review June 17, 2020 22:45
@kimadeline
Copy link
Author

image

🥳

@kimadeline kimadeline merged commit 98e6aa5 into microsoft:master Jun 18, 2020
@kimadeline kimadeline deleted the 12372-ci-windows-pytest branch June 18, 2020 02:04
@kimadeline kimadeline mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@int19h int19h int19h approved these changes

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimadeline @int19h @rchiodo