Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a one-off transfer of existing values for python.pythonPath setting to new Interpreter storage if in DeprecatePythonPath experiment #11053

Merged
merged 8 commits into from
Apr 12, 2020

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Apr 9, 2020

Recommended to hide whitespaces before reviewing

For #11052

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@karrtikr karrtikr marked this pull request as draft April 9, 2020 21:07
@kimadeline kimadeline requested review from kimadeline and removed request for kimadeline April 9, 2020 21:27
@kimadeline
Copy link

Lol I wanted to dismiss my approval, seems like the closest I can do is to re-request a review

@codecov-io
Copy link

codecov-io commented Apr 10, 2020

Codecov Report

Merging #11053 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11053      +/-   ##
==========================================
+ Coverage   61.27%   61.44%   +0.17%     
==========================================
  Files         593      597       +4     
  Lines       32492    32792     +300     
  Branches     4593     4638      +45     
==========================================
+ Hits        19910    20150     +240     
- Misses      11580    11624      +44     
- Partials     1002     1018      +16     
Impacted Files Coverage Δ
src/client/activation/activationManager.ts 95.37% <100.00%> (+0.13%) ⬆️
src/client/common/interpreterPathService.ts 97.77% <100.00%> (+1.55%) ⬆️
src/client/common/types.ts 100.00% <100.00%> (ø)
src/client/interpreter/autoSelection/constants.ts 100.00% <100.00%> (ø)
src/client/common/net/httpClient.ts 72.50% <0.00%> (-18.13%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5c808...7680614. Read the comment docs.

@karrtikr karrtikr requested review from kimadeline and removed request for kimadeline April 10, 2020 14:46
@karrtikr karrtikr marked this pull request as ready for review April 10, 2020 15:36
@karrtikr
Copy link
Author

karrtikr commented Apr 10, 2020

@kimadeline Yeah your approval doesn't go away (good for me!)
And now it seems the friendly bot @Microsoft-lgtm will also bug us...

Anyways, I fixed a bug I found in the process, so please re-review.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karrtikr karrtikr merged commit 56051b8 into microsoft:master Apr 12, 2020
@karrtikr karrtikr deleted the oneoffimport branch April 12, 2020 03:52
@lock lock bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants