Secondary fix for 9523 - Exception for loading should show in the ouptut #10990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #10990 +/- ##
==========================================
- Coverage 60.75% 60.73% -0.03%
==========================================
Files 583 583
Lines 31731 31731
Branches 4519 4519
==========================================
- Hits 19279 19272 -7
- Misses 11466 11471 +5
- Partials 986 988 +2
Continue to review full report at Codecov.
|
IanMatthewHuff
approved these changes
Apr 6, 2020
| @@ -40,6 +40,7 @@ export interface ICellViewModel { | |||
| hasBeenRun: boolean; | |||
| runDuringDebug?: boolean; | |||
| codeVersion?: number; | |||
| uiSideError?: string; | |||
There was a problem hiding this comment.
This change makes sense to me just architecturally. We want to render this, but it's not really a cell output.
DavidKutu
approved these changes
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9523
Initial fix for this issue was insufficient. Added a UI side only value to the cell view model to represent errors found when rendering.