Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all extension-internal uses of Python "isolated". #10943

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Apr 2, 2020

For #10681.

This change updates all other internal uses of Python in the extension to run "isolated".

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #10943 into master will decrease coverage by 0.00%.
The diff coverage is 69.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10943      +/-   ##
==========================================
- Coverage   61.31%   61.31%   -0.01%     
==========================================
  Files         591      592       +1     
  Lines       32360    32434      +74     
  Branches     4585     4588       +3     
==========================================
+ Hits        19842    19886      +44     
- Misses      11518    11544      +26     
- Partials     1000     1004       +4     
Impacted Files Coverage Δ
src/client/providers/jediProxy.ts 23.60% <16.66%> (+0.11%) ⬆️
src/client/common/process/pythonDaemonPool.ts 70.00% <42.85%> (-0.52%) ⬇️
src/client/common/process/internal/python.ts 60.78% <60.78%> (ø)
src/client/common/configSettings.ts 69.67% <69.67%> (-0.15%) ⬇️
src/client/interpreter/interpreterVersion.ts 88.00% <87.50%> (+2.28%) ⬆️
src/client/common/installer/moduleInstaller.ts 94.66% <100.00%> (+0.07%) ⬆️
src/client/common/process/pythonEnvironment.ts 88.88% <100.00%> (+0.42%) ⬆️
src/client/common/process/pythonProcess.ts 97.22% <100.00%> (+0.25%) ⬆️
...ent/interpreter/display/shebangCodeLensProvider.ts 96.07% <100.00%> (+0.07%) ⬆️
...nterpreter/locators/services/currentPathService.ts 90.62% <100.00%> (+0.30%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccebdcf...17b1f64. Read the comment docs.

@ericsnowcurrently ericsnowcurrently force-pushed the proc-internal-python-isolated branch 2 times, most recently from 5dbf993 to b63bb02 Compare April 7, 2020 19:45
@ericsnowcurrently ericsnowcurrently force-pushed the proc-internal-python-isolated branch 5 times, most recently from b077dcc to d29c79d Compare April 8, 2020 20:04
@ericsnowcurrently ericsnowcurrently force-pushed the proc-internal-python-isolated branch from d29c79d to 9fd08d1 Compare April 8, 2020 20:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericsnowcurrently ericsnowcurrently merged commit bd942a0 into microsoft:master Apr 8, 2020
@ericsnowcurrently ericsnowcurrently deleted the proc-internal-python-isolated branch April 8, 2020 22:02
@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants