Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry for .env files #10833

Merged
merged 53 commits into from
Apr 6, 2020

Conversation

kimadeline
Copy link

For #10780

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Mar 27, 2020

Codecov Report

Merging #10833 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10833   +/-   ##
=======================================
  Coverage   60.73%   60.73%           
=======================================
  Files         582      582           
  Lines       31716    31716           
  Branches     4516     4516           
=======================================
  Hits        19263    19263           
  Misses      11466    11466           
  Partials      987      987           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae05174...ae05174. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review March 31, 2020 22:49
src/client/activation/activationManager.ts Outdated Show resolved Hide resolved
src/client/common/configSettings.ts Outdated Show resolved Hide resolved
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a few comments.

src/client/telemetry/index.ts Outdated Show resolved Hide resolved
src/client/telemetry/envFileTelemetry.ts Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimadeline kimadeline merged commit 2b880c9 into microsoft:master Apr 6, 2020
@kimadeline kimadeline deleted the 10780-telemetry-env-files branch April 6, 2020 16:46
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants