Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a script to run scripts/modules in an isolated way. #10670

Merged
merged 3 commits into from
Mar 25, 2020
Merged

Add a script to run scripts/modules in an isolated way. #10670

merged 3 commits into from
Mar 25, 2020

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Mar 19, 2020 •
edited by karthiknadig
Loading

For #10681

We'll use this for our security hardening.

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Mar 19, 2020
@karthiknadig
Copy link
Member

Created #10681 to track this.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kimadeline
kimadeline approved these changes Mar 24, 2020
View reviewed changes
Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we write tests for this?

@ericsnowcurrently
Copy link
Member Author

It's trivial enough that I don't think tests will add much. Plus, it will be used in critical parts of the extension so any problem will be revealed immediately. :)

@ericsnowcurrently ericsnowcurrently merged commit 39a2228 into microsoft:master Mar 25, 2020
@ericsnowcurrently ericsnowcurrently deleted the run-isolated-script branch March 25, 2020 20:55
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kimadeline kimadeline kimadeline approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @karthiknadig @kimadeline