Skip to content

Fix quoting logic to escape special characters in exec path #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

Fix quoting logic to escape special characters in exec path #890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/features/execution/execUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
export function quoteStringIfNecessary(arg: string): string {
if (arg.indexOf(' ') >= 0 && !(arg.startsWith('"') && arg.endsWith('"'))) {
return `"${arg}"`;
// Always return if already quoted to avoid double-quoting
if (arg.startsWith('"') && arg.endsWith('"')) {
return arg;
}
return arg;

// Quote if contains common shell special characters that are problematic across multiple shells
// Includes: space, &, |, <, >, ;, ', ", `, (, ), [, ], {, }, $
const needsQuoting = /[\s&|<>;'"`()\[\]{}$]/.test(arg);

return needsQuoting ? `"${arg}"` : arg;
}

export function quoteArgs(args: string[]): string[] {
Expand Down
Loading