Skip to content

Fix when clause for activate/deactivate button #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix when clause for activate/deactivate button #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,12 @@ The extension uses `pip` as the default package manager. You can change this by

## Settings Reference

| Setting (python-envs.) | Default | Description |
| ---------------------- | ------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| defaultEnvManager | `"ms-python.python:venv"` | The default environment manager used for creating and managing environments. |
| defaultPackageManager | `"ms-python.python:pip"` | The default package manager to use for installing and managing packages. This is often dictated by the default environment manager but can be customized. |
| pythonProjects | `[]` | A list of Python workspaces, specified by the path, in which you can set particular environment and package managers. You can set information for a workspace as `[{"path": "/path/to/workspace", "envManager": "ms-python.python:venv", "packageManager": "ms-python.python:pip"]}`. |
| Setting (python-envs.) | Default | Description |
| --------------------------- | ------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| defaultEnvManager | `"ms-python.python:venv"` | The default environment manager used for creating and managing environments. |
| defaultPackageManager | `"ms-python.python:pip"` | The default package manager to use for installing and managing packages. This is often dictated by the default environment manager but can be customized. |
| pythonProjects | `[]` | A list of Python workspaces, specified by the path, in which you can set particular environment and package managers. You can set information for a workspace as `[{"path": "/path/to/workspace", "envManager": "ms-python.python:venv", "packageManager": "ms-python.python:pip"]}`. |
| terminal.showActivateButton | `false` | [experimental] Show a button in the terminal to activate/deactivate the current environment for the terminal. This button is only shown if the active terminal is associated with a project that has an activatable environment. |

## API Reference (proposed)

Expand Down
18 changes: 9 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@
}
}
},
"python-envs.showActivateButton": {
"python-envs.terminal.showActivateButton": {
"type": "boolean",
"description": "%python-envs.showActivateButton.description%",
"description": "%python-envs.terminal.showActivateButton.description%",
"default": false,
"scope": "machine",
"tags": [
Expand Down Expand Up @@ -202,7 +202,7 @@
"command": "python-envs.terminal.activate",
"title": "%python-envs.terminal.activate.title%",
"category": "Python Envs",
"icon": "$(zap)"
"icon": "$(python)"
},
{
"command": "python-envs.terminal.deactivate",
Expand Down Expand Up @@ -267,11 +267,11 @@
},
{
"command": "python-envs.terminal.activate",
"when": "false"
"when": "pythonTerminalActivation"
},
{
"command": "python-envs.terminal.deactivate",
"when": "false"
"when": "pythonTerminalActivation"
}
],
"view/item/context": [
Expand Down Expand Up @@ -357,12 +357,12 @@
{
"command": "python-envs.terminal.activate",
"group": "navigation",
"when": "view == terminal && pythonTerminalActivation && !pythonTerminalActivated"
"when": "view == terminal && config.python-envs.terminal.showActivateButton && pythonTerminalActivation && !pythonTerminalActivated"
},
{
"command": "python-envs.terminal.deactivate",
"group": "navigation",
"when": "view == terminal && pythonTerminalActivation && pythonTerminalActivated"
"when": "view == terminal && config.python-envs.terminal.showActivateButton && pythonTerminalActivation && pythonTerminalActivated"
}
],
"explorer/context": [
Expand All @@ -387,11 +387,11 @@
"terminal/title/context": [
{
"command": "python-envs.terminal.activate",
"when": "config.python-envs.showActivateButton && pythonTerminalActivation && !pythonTerminalActivated"
"when": "pythonTerminalActivation && !pythonTerminalActivated"
},
{
"command": "python-envs.terminal.deactivate",
"when": "config.python-envs.showActivateButton && pythonTerminalActivation && pythonTerminalActivated"
"when": "pythonTerminalActivation && pythonTerminalActivated"
}
]
},
Expand Down
2 changes: 1 addition & 1 deletion package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"python-envs.pythonProjects.path.description": "The path to a folder or file in the workspace to be treated as a Python project.",
"python-envs.pythonProjects.envManager.description": "The environment manager for creating and managing environments for this project.",
"python-envs.pythonProjects.packageManager.description": "The package manager for managing packages in environments for this project.",
"python-envs.showActivateButton.description": "Whether to show the 'Activate' button in the terminal menu",
"python-envs.terminal.showActivateButton.description": "Whether to show the 'Activate' button in the terminal menu",

"python-envs.setEnvManager.title": "Set Environment Manager",
"python-envs.setPkgManager.title": "Set Package Manager",
Expand Down
Loading