Log spawning of processes #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Aug 23, 2025
| cp.exec(command, (err, stdout) => { | ||
| if (err) { | ||
| traceVerbose(`Error running command: ${command}`, err); | ||
| traceError(`Error running command: ${command} (${timer.elapsedTime})`, err); |
There was a problem hiding this comment.
Surely if success is info, then failure must be warning/error or info, but not something less
DonJayamanne
commented
Aug 23, 2025
| return available.promise; | ||
| } | ||
|
|
||
| log?.info(`Running: uv --version`); |
There was a problem hiding this comment.
I don't think the code is right here, as log is optional
And looking at the calling code, it isn't passed
Not sure why, I'd try to resolve this in debt, as logger shouldn't be optional. we either turn off logging or the like, but wouldn't make the logger component optional.
DonJayamanne
commented
Aug 23, 2025
| const deferred = createDeferred<string>(); | ||
| args = quoteArgs(args); | ||
| const timer = new StopWatch(); | ||
| deferred.promise.finally(() => traceInfo(`Ran conda in ${timer.elapsedTime}: ${conda} ${args.join(' ')}`)); |
There was a problem hiding this comment.
We haven't logged this at all, now we will.
We know conda is slow
DonJayamanne
commented
Aug 23, 2025
| const exec = promisify(cp.exec); | ||
| function execCommand(command: string) { | ||
| const timer = new StopWatch(); | ||
| return promisify(cp.exec)(command, { windowsHide: true }).finally(() => |
There was a problem hiding this comment.
We haven't logged this at all, now we will.
I believe we've seen delays in reading registry in the past as well.
DonJayamanne
requested review from
eleanorjboyd and
karthiknadig
and removed request for
karthiknadig
eleanorjboyd
approved these changes
Aug 25, 2025
NguyenCuong1989
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/vscode#266411