Skip to content

feat: implement caching for conda hook path to optimize filesystem checks #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

feat: implement caching for conda hook path to optimize filesystem checks #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 43 additions & 27 deletions src/managers/conda/condaUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,6 +1053,9 @@ export async function checkForNoPythonCondaEnvironment(
return environment;
}

// Cache for conda hook paths to avoid redundant filesystem checks
const condaHookPathCache = new Map<string, Promise<string>>();

/**
* Returns the best guess path to conda-hook.ps1 given a conda executable path.
*
Expand All @@ -1063,32 +1066,45 @@ export async function checkForNoPythonCondaEnvironment(
* - etc/profile.d/
*/
async function getCondaHookPs1Path(condaPath: string): Promise<string> {
const condaRoot = path.dirname(path.dirname(condaPath));

const condaRootCandidates: string[] = [
path.join(condaRoot, 'shell', 'condabin'),
path.join(condaRoot, 'Library', 'shell', 'condabin'),
path.join(condaRoot, 'condabin'),
path.join(condaRoot, 'etc', 'profile.d'),
];

const checks = condaRootCandidates.map(async (hookSearchDir) => {
const candidate = path.join(hookSearchDir, 'conda-hook.ps1');
if (await fse.pathExists(candidate)) {
traceInfo(`Conda hook found at: ${candidate}`);
return candidate;
}
return undefined;
});
const results = await Promise.all(checks);
const found = results.find(Boolean);
if (found) {
return found as string;
// Check cache first
const cachedPath = condaHookPathCache.get(condaPath);
if (cachedPath) {
return cachedPath;
}
traceError(
`Conda hook not found in any of the expected locations: ${condaRootCandidates.join(
', ',
)}, given conda path: ${condaPath}`,
);
return path.join(condaRoot, 'shell', 'condabin', 'conda-hook.ps1');

// Create the promise for finding the hook path
const hookPathPromise = (async () => {
const condaRoot = path.dirname(path.dirname(condaPath));

const condaRootCandidates: string[] = [
path.join(condaRoot, 'shell', 'condabin'),
path.join(condaRoot, 'Library', 'shell', 'condabin'),
path.join(condaRoot, 'condabin'),
path.join(condaRoot, 'etc', 'profile.d'),
];

const checks = condaRootCandidates.map(async (hookSearchDir) => {
const candidate = path.join(hookSearchDir, 'conda-hook.ps1');
if (await fse.pathExists(candidate)) {
traceInfo(`Conda hook found at: ${candidate}`);
return candidate;
}
return undefined;
});
const results = await Promise.all(checks);
const found = results.find(Boolean);
if (found) {
return found as string;
}
traceError(
`Conda hook not found in any of the expected locations: ${condaRootCandidates.join(
', ',
)}, given conda path: ${condaPath}`,
);
return path.join(condaRoot, 'shell', 'condabin', 'conda-hook.ps1');
})();

// Store in cache and return
condaHookPathCache.set(condaPath, hookPathPromise);
return hookPathPromise;
}