Skip to content

Conversation

@eleanorjboyd
Copy link
Member

fixes #662

only follow disablement if both settings are set

@eleanorjboyd eleanorjboyd requested review from cwebster-99 and karthiknadig and removed request for cwebster-99 July 29, 2025 15:20
@eleanorjboyd
Copy link
Member Author

eleanorjboyd commented Jul 29, 2025

This is how it should work with this update- are we happy with this design?

"python.terminal.activateEnvironment" python-envs.terminal.autoActivationType Will auto-activate?
false 🚫 off 🚫 🚫
false 🚫 shellStartup or Command ✅ shellStartup or Command ✅
true ✅ off 🚫 🚫
true ✅ shellStartup or Command ✅ shellStartup or Command ✅
unset 🟡 off 🚫 🚫
unset 🟡 shellStartup or Command ✅ shellStartup or Command ✅
false 🚫 unset 🟡 (update this to false) 🚫
true ✅ unset 🟡

@eleanorjboyd
Copy link
Member Author

update table to reflect new system: Priority goes to the new setting if explicitly set but otherwise we fall back to old setting. If old setting is "off" we update the new setting to reflect that user preference going forward

@eleanorjboyd eleanorjboyd marked this pull request as ready for review July 31, 2025 15:29
@eleanorjboyd eleanorjboyd requested a review from anthonykim1 July 31, 2025 15:29
@vs-code-engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@eleanorjboyd eleanorjboyd merged commit ed4c551 into microsoft:main Jul 31, 2025
6 checks passed
eleanorjboyd added a commit to eleanorjboyd/vscode-python-environments that referenced this pull request Aug 11, 2025
NguyenCuong1989 referenced this pull request in NguyenCuong1989/vscode-python-environments Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

does not respect "python.terminal.activateEnvironment": false config

2 participants