Skip to content

Conversation

Copy link
Contributor

Copilot AI commented May 21, 2025

fixes #58

Problem

When a user selects "Set As Workspace Environment" for an environment that's already selected as the workspace environment, there's no feedback provided to the user. This can be confusing, as it appears that nothing happens when clicking the button.

Solution

This PR adds feedback to users when they attempt to select an environment that's already set as the workspace environment:

  1. When a user has one folder/project open and tries to set the same environment that's already selected
  2. The user will now see an information message: "This environment is already selected for the workspace." but its more verbose

Fixes #58 and refined by @eleanorjboyd

Copilot AI changed the title [WIP] re-select "set as workspace env" does nothing Add notification when re-selecting the same workspace environment May 21, 2025
Copilot AI requested a review from eleanorjboyd May 21, 2025 17:01
Copilot finished work on behalf of eleanorjboyd May 21, 2025 17:01
@eleanorjboyd eleanorjboyd requested a review from karthiknadig May 21, 2025 20:13
@eleanorjboyd eleanorjboyd marked this pull request as ready for review May 21, 2025 20:13
@eleanorjboyd eleanorjboyd reopened this May 22, 2025
@eleanorjboyd eleanorjboyd enabled auto-merge (squash) May 22, 2025 16:49
@eleanorjboyd eleanorjboyd merged commit 522ffac into main May 22, 2025
14 checks passed
@eleanorjboyd eleanorjboyd deleted the copilot/fix-58 branch May 22, 2025 17:13
@eleanorjboyd eleanorjboyd added this to the May 2025 milestone May 30, 2025
NguyenCuong1989 referenced this pull request in NguyenCuong1989/vscode-python-environments Oct 23, 2025
fixes microsoft/vscode-python-environments#58

## Problem

When a user selects "Set As Workspace Environment" for an environment
that's already selected as the workspace environment, there's no
feedback provided to the user. This can be confusing, as it appears that
nothing happens when clicking the button.

## Solution

This PR adds feedback to users when they attempt to select an
environment that's already set as the workspace environment:

1. When a user has one folder/project open and tries to set the same
environment that's already selected
2. The user will now see an information message: "This environment is
already selected for the workspace." but its more verbose

Fixes #58 and refined by @eleanorjboyd

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: eleanorjboyd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

re-select "set as workspace env" does nothing

4 participants