Skip to content

Conversation

@DonJayamanne
Copy link
Contributor

No description provided.

@DonJayamanne DonJayamanne requested review from eleanorjboyd and karthiknadig and removed request for karthiknadig May 14, 2025 03:03
"toolReferenceName": "pythonGetEnvironmentInfo",
"tags": [],
"tags": [
"ms-python.python"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be used elsewhere.

{
"name": "python_install_package",
"displayName": "Install Python Package",
"userDescription": "Installs Python packages in the given workspace",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if its worth clarifying that it isn't the workspace but instead installed in the environment connected to the resource provided as an arg? Or do we think that will be too confusing? (also noticing the modelDescription is similar so this is likely a mistake I made earlier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do that for the model? hence not sure how useful it would be.
I would have thought more useful messages/info should be for the model vs user.
Are you suggesting we change this for the model as well.

As for user, I'm not sure it will make much sense to the user. I'm assuming the user would expect that behaviour out of the box.

@DonJayamanne DonJayamanne merged commit 35d5997 into main May 14, 2025
10 checks passed
@DonJayamanne DonJayamanne deleted the don/single-meadowlark branch May 14, 2025 21:11
NguyenCuong1989 referenced this pull request in NguyenCuong1989/vscode-python-environments Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants