Skip to content

Fix bug with selecting global python #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix bug with selecting global python #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/features/envCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
ProjectItem,
ProjectEnvironment,
ProjectPackageRootTreeItem,
GlobalProjectItem,
} from './views/treeViewItems';
import { Common } from '../common/localize';
import { pickEnvironment } from '../common/pickers/environments';
Expand Down Expand Up @@ -213,10 +214,15 @@ export async function setEnvironmentCommand(
if (context instanceof PythonEnvTreeItem) {
try {
const view = context as PythonEnvTreeItem;
const projects = await pickProjectMany(wm.getProjects());
if (projects && projects.length > 0) {
const uris = projects.map((p) => p.uri);
await em.setEnvironments(uris, view.environment);
const projects = wm.getProjects();
if (projects.length > 0) {
const selected = await pickProjectMany(projects);
if (selected && selected.length > 0) {
const uris = selected.map((p) => p.uri);
await em.setEnvironments(uris, view.environment);
}
} else {
await em.setEnvironments('global', view.environment);
}
} catch (ex) {
if (ex === QuickInputButtons.Back) {
Expand All @@ -227,12 +233,14 @@ export async function setEnvironmentCommand(
} else if (context instanceof ProjectItem) {
const view = context as ProjectItem;
await setEnvironmentCommand([view.project.uri], em, wm);
} else if (context instanceof GlobalProjectItem) {
await setEnvironmentCommand(undefined, em, wm);
} else if (context instanceof Uri) {
await setEnvironmentCommand([context], em, wm);
} else if (context === undefined) {
try {
const projects = wm.getProjects();
if (projects && projects.length > 0) {
if (projects.length > 0) {
const selected = await pickProjectMany(projects);
if (selected && selected.length > 0) {
const uris = selected.map((p) => p.uri);
Expand Down
Loading